Skip to content
This repository was archived by the owner on Jan 23, 2024. It is now read-only.

Conversation

@yamilethmedina
Copy link

No description provided.

@lippytak lippytak added the ready label Jul 12, 2016
Rebase pull request and update master branch
@ErnieAtLYD
Copy link

@daguar: WE HAVE A PROPER GIT REBASE. I REPEAT, WE HAVE A PROPER GIT REBASE.
Thanks to @yamilethmedina for being patient! 💃

@daguar
Copy link
Contributor

daguar commented Aug 9, 2016

Yay! Glad the rebase was sorted out.

This still has a tiny bit more work before we can merge — specifically, please remove the UTF-8 stuff. As mentioned in a previous comment on the code, the headers are both unnecessary and (more importantly) changing to UTF-8 in this way breaks characters like ñ and ó that we use for the Spanish translations.

@daguar
Copy link
Contributor

daguar commented Aug 17, 2016

Hey @yamilethmedina — very close! Could you do one more commit that reverts the removal of all the accents in Spanish that happened with the UTF-8 plugin?

@yamilethmedina
Copy link
Author

@daguar It should be done now! I guess the accents ended up being removed by one of the many merges. I made sure to add them back.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants