Skip to content

Add App Review section to app detail page#9

Merged
trmquang93 merged 1 commit intomainfrom
feature/app-review-section
Mar 24, 2026
Merged

Add App Review section to app detail page#9
trmquang93 merged 1 commit intomainfrom
feature/app-review-section

Conversation

@trmquang93
Copy link
Copy Markdown
Contributor

Summary

  • Adds a new App Review section to the app detail page showing review submission history
  • New backend endpoint GET /api/apps/:appId/review-submissions fetches from ASC API /v1/apps/{id}/reviewSubmissions
  • Two parallel API calls: one for UNRESOLVED_ISSUES (messages), one for COMPLETE/CANCELING (submissions)
  • Derives "Removed" status from review submission item states when all items are REMOVED
  • New AppReviewSection component with Messages and Submissions tables

Limitations

  • The ASC "Messages" section for post-distribution compliance reviews (with "Grace Period Ends") is not exposed via the public ASC API. The messages sub-section only shows active UNRESOLVED_ISSUES during review.

Test plan

  • Navigate to an app detail page and verify the App Review section appears between App Store Info and Version History
  • Verify submissions table shows correct versions, submitted by, item counts, and statuses
  • Verify "Removed" status displays correctly for submissions where all items were removed
  • Verify empty state shows gracefully for apps with no review submissions
  • Verify cache invalidation works after submitting a version for review
  • Run npm run build to confirm no build errors

Add a new App Review section between App Store Info and Version History
on the app detail page, showing review submission history from the ASC API.

Backend:
- New GET /api/apps/:appId/review-submissions endpoint
- Fetches from /v1/apps/{id}/reviewSubmissions with two parallel calls:
  one filtered for UNRESOLVED_ISSUES (messages), one for COMPLETE/CANCELING
  (submissions)
- Normalizes JSON:API response resolving version strings, actor names, and
  item counts from included relationships
- Derives "Removed" status from item states when all items are REMOVED
- 5-min cache with invalidation on submit-for-review

Frontend:
- New AppReviewSection component with Messages and Submissions tables
- fetchReviewSubmissions API client function
- Loading, error, and empty states handled gracefully
@trmquang93 trmquang93 merged commit e6bcbb3 into main Mar 24, 2026
@github-actions github-actions bot deleted the feature/app-review-section branch March 24, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant