Skip to content

Add pull request permissions and update install script in GitHub Actions workflow #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arpan-206 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add pull request permissions and update install script in GitHub Actions workflow #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ on:

permissions:
contents: write
pull-requests: write

jobs:
goreleaser:
Expand Down Expand Up @@ -33,3 +34,53 @@ jobs:
# Your GoReleaser Pro key, if you are using the 'goreleaser-pro'
# distribution:
# GORELEASER_KEY: ${{ secrets.GORELEASER_KEY }}

update-install-script:
needs: goreleaser
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
token: ${{ secrets.CODECRAFTERS_BOT_GITHUB_TOKEN }}

- name: Extract version from tag
id: version
run: |
VERSION="${GITHUB_REF#refs/tags/}"
echo "version=$VERSION" >> $GITHUB_OUTPUT
echo "Extracted version: $VERSION"

- name: Update install.sh
run: |
VERSION="${{ steps.version.outputs.version }}"
sed -i.bak "s/VERSION=\${CODECRAFTERS_CLI_VERSION:-v[0-9]*}/VERSION=\${CODECRAFTERS_CLI_VERSION:-$VERSION}/" install.sh
Copy link
Copy Markdown

@cursor cursor bot Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unescaped Version Variable in Sed Command

The sed command in the update-install-script job uses the $VERSION variable unescaped in its replacement string. This can cause the command to fail or incorrectly modify install.sh if the version tag contains sed special characters like /, &, or \.

Fix in Cursor Fix in Web

rm install.sh.bak
echo "Updated install.sh with version $VERSION"

- name: Check for changes
id: changes
run: |
if git diff --quiet install.sh; then
echo "changed=false" >> $GITHUB_OUTPUT
echo "No changes detected"
else
echo "changed=true" >> $GITHUB_OUTPUT
echo "Changes detected:"
git diff install.sh
fi

- name: Create Pull Request
if: steps.changes.outputs.changed == 'true'
uses: peter-evans/create-pull-request@v6
with:
token: ${{ secrets.CODECRAFTERS_BOT_GITHUB_TOKEN }}
commit-message: "update default CODECRAFTERS_CLI_VERSION to ${{ steps.version.outputs.version }} in install.sh"
title: "Update CLI version to ${{ steps.version.outputs.version }}"
body: |
This PR automatically updates the default CLI version in `install.sh` to match the newly released version.

**Version:** ${{ steps.version.outputs.version }}

This PR was automatically generated by the [publish workflow](https://github.com/${{ github.repository }}/actions/workflows/publish.yml).
branch: update-cli-version-${{ steps.version.outputs.version }}
delete-branch: true