fix: remove ValidatedString and TestrunOrSkipped#85
Open
joseph-sentry wants to merge 1 commit intomainfrom
Open
fix: remove ValidatedString and TestrunOrSkipped#85joseph-sentry wants to merge 1 commit intomainfrom
joseph-sentry wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
- Coverage 95.63% 94.67% -0.97%
==========================================
Files 17 16 -1
Lines 2337 2027 -310
==========================================
- Hits 2235 1919 -316
- Misses 102 108 +6 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #85 will not alter performanceComparing Summary
|
I previously added these because we were having issues storing very long test names and I wanted to "validate" the data that came in to make sure that we're not including random strings for test names that might include source code. The main problem was that we weren't able to index that data in timescale and that was causing issues. I've since removed those indexes and if we have to index on names we'll have to use full text indexes next time, but for now we don't need this anymore. In the future, we'll likely have to add some mechanism for users to "ignore" irrelevant tests in the UI, or filter the names of tests. In any case, the scope of this library is to simply parse a JUnit XML file, so we should stick to that here, and avoid trying to do more.
9543731 to
3e176e8
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously added these because we were having issues storing very long test names and I wanted to "validate" the data that came in to make sure that we're not including random strings for test names that might include source code. The main problem was that we weren't able to index that data in timescale and that was causing issues. I've since removed those indexes and if we have to index on names we'll have to use full text indexes next time, but for now we don't need this anymore. In the future, we'll likely have to add some mechanism for users to "ignore" irrelevant tests in the UI, or filter the names of tests. In any case, the scope of this library is to simply parse a JUnit XML file, so we should stick to that here, and avoid trying to do more.