Skip to content

Improve usability of license.py#28

Open
scottgigante wants to merge 1 commit intocodecov:mainfrom
scottgigante:patch-1
Open

Improve usability of license.py#28
scottgigante wants to merge 1 commit intocodecov:mainfrom
scottgigante:patch-1

Conversation

@scottgigante
Copy link

Removes unused arguments and marks required subparser as required.

Before:

✗ python scripts/license.py
Traceback (most recent call last):
  File "/Users/scottgigante/git/ctvc/codecov/scripts/license.py", line 93, in <module>
    main()
  File "/Users/scottgigante/git/ctvc/codecov/scripts/license.py", line 83, in main
    print(pref.command)
          ^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'command'

After:

✗ python scripts/license.py
usage: codecov key gen [-h] {new,check} ...
codecov key gen: error: the following arguments are required: {new,check}

Removes unused arguments and marks required subparser as required.

Before:
```
✗ python scripts/license.py
Traceback (most recent call last):
  File "/Users/scottgigante/git/ctvc/codecov/scripts/license.py", line 93, in <module>
    main()
  File "/Users/scottgigante/git/ctvc/codecov/scripts/license.py", line 83, in main
    print(pref.command)
          ^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'command'
```

After:
```
✗ python scripts/license.py
usage: codecov key gen [-h] {new,check} ...
codecov key gen: error: the following arguments are required: {new,check}
```
@parkcheolhong
Copy link

감사합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants