Conversation
This introduces a tree-shaking performance issue by importing the entire
date-fns library (~65KB minified) instead of only the specific functions
needed (formatDistanceToNow, fromUnixTime, parseISO).
Impact: Increases bundle size significantly as the entire date-fns library
will be included even though only 3 functions are used.
Before (optimized):
import { formatDistanceToNow, fromUnixTime, parseISO } from 'date-fns'
After (poor tree-shaking):
import * as dateFns from 'date-fns'
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3939 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 828 828
Lines 15099 15101 +2
Branches 4326 4320 -6
=======================================
+ Hits 14891 14893 +2
Misses 200 200
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Bundle ReportBundle size has no change ✅ |
Bundle ReportBundle size has no change ✅ |
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3939 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 828 828
Lines 15099 15101 +2
Branches 4326 4320 -6
=======================================
+ Hits 14891 14893 +2
Misses 200 200
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3939 +/- ##
==========================================
+ Coverage 96.54% 98.62% +2.07%
==========================================
Files 828 828
Lines 15099 15101 +2
Branches 4318 4320 +2
==========================================
+ Hits 14578 14893 +315
+ Misses 466 200 -266
+ Partials 55 8 -47
... and 43 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
2 participants
Updating some imports to clean up the code
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.