This repository was archived by the owner on Jul 16, 2025. It is now read-only.
Merged
Conversation
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This adds Windows and MacOS to our CI test matrix.
d7318cd to
374cbac
Compare
412d612 to
d710977
Compare
joseph-sentry
suggested changes
Mar 26, 2025
Contributor
joseph-sentry
left a comment
There was a problem hiding this comment.
i think for the changes in folder_searcher to work with file finding you would need to make sure that the multipart_include_regex is also using as_posix(), this happens here:
joseph-sentry
approved these changes
Mar 26, 2025
Contributor
joseph-sentry
left a comment
There was a problem hiding this comment.
i think there's some required checks settings in the repo which is causing the CI to expect certain checks with diff names @thomasrockhu-codecov do you have perms to change those?
Contributor
|
@joseph-sentry done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Windows and macOS to our CI test matrix.
It also changes quite a lot of internal functionality and tests to use
Path.as_posix()which always prints paths with forward slashes.This was primarily done to make a ton of tests work on Windows, but IMO it is also a good idea to normalize paths internally to use forward slashes.
As #661 is primarily an issue on Windows, it would be nice to run tests on Windows as well.
And also macOS as well, why not. This should cover the major OSs that folks will be running in their own CI jobs that are using the CLI.