fix: download CLI to temp dir and retry GPG key import#1916
Closed
thomasrockhu-codecov wants to merge 1 commit intomainfrom
Closed
fix: download CLI to temp dir and retry GPG key import#1916thomasrockhu-codecov wants to merge 1 commit intomainfrom
thomasrockhu-codecov wants to merge 1 commit intomainfrom
Conversation
Fixes two regressions in the wrapper script: 1. Dirty git state (#1851, #1804): The binary, SHA256SUM, and SHA256SUM.sig files were downloaded into the working directory (repo root) and never cleaned up. Now downloads to a mktemp -d directory with an EXIT trap that removes it automatically. 2. GPG import failures (#1876): The key import used `echo "$(curl ...)" | gpg --import` which strips trailing newlines from the PGP key, had no retries, and no error checking. Now pipes curl directly to gpg with a 3-attempt retry loop and explicit failure reporting. Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1916 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 2 2
Lines 35 35
=======================================
Hits 34 34
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Closing — these changes belong in codecov/wrapper, not here. Opening PR there instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mktemp -d) instead of the repo working directory. AnEXITtrap automatically cleans up the temp dir when the script finishes. No more leftovercodecov,codecov.SHA256SUM,codecov.SHA256SUM.sigfiles pollutinggit status.echo "$(curl -s ...)" | gpg --importpattern (which strips trailing newlines and has no error handling) with a 3-attempt retry loop that pipescurl -sfdirectly togpg --import, with explicit failure reporting.Closes #1851
Closes #1804
Fixes #1876
Test plan
CC_BINARY_LOCATIONpath: binary is moved to the specified location correctlyCC_DOWNLOAD_ONLYpath: binary is copied to working dir before exitskip_validationpath: binary downloads to temp dir, validation is skippedgit statusis clean after action completes (the core bug fix)Notes
dist/codecov.shis sourced from thecodecov/wrappersubmodule. The same changes should be upstreamed to that repo.codecov/codecov-cli.Made with Cursor