Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential bug: The codeql-action@v4 upgrade requires Node.js v24, which may not be available on all ubuntu-latest runners, potentially causing workflow failures.
  • Description: The upgrade of github/codeql-action to v4 introduces a requirement for Node.js v24. The workflow is configured to use runs-on: ubuntu-latest. However, the ubuntu-latest runner environment is undergoing a gradual migration and may not yet have Node.js v24 installed by default. This mismatch can cause the CodeQL workflow to fail with a runtime error if it executes on a runner instance that lacks the required Node.js version.

  • Suggested fix: Explicitly configure the GitHub Actions runner environment to use Node.js v24. Add a setup-node step before the codeql-action/init step, for example: - uses: actions/setup-node@v4 with: node-version: '24'. This will ensure the required runtime is available before the CodeQL action runs.
    severity: 0.65, confidence: 0.9

Did we get this right? 👍 / 👎 to inform future reviews.

uses: github/codeql-action/init@v3.30.0
uses: github/codeql-action/init@v4.30.9
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -52,7 +52,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v3.30.0
uses: github/codeql-action/autobuild@v4.30.9

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl
Expand All @@ -66,4 +66,4 @@ jobs:
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3.30.0
uses: github/codeql-action/analyze@v4.30.9
2 changes: 1 addition & 1 deletion .github/workflows/scorecards-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@ jobs:

# Upload the results to GitHub's code scanning dashboard.
- name: "Upload to code-scanning"
uses: github/codeql-action/upload-sarif@v3.30.0 # v1.0.26
uses: github/codeql-action/upload-sarif@v4.30.9 # v1.0.26
with:
sarif_file: results.sarif
Loading