Skip to content

Conversation

@ceciliastevens
Copy link
Contributor

Marks functionality that is superseded by the Incydr SDK (https://developer.code42.com/) as deprecated.

Copy link
Contributor

@tora-kozic tora-kozic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested this alongside the cli update? Do the py42 deprecations carry over to that?

If we add a deprecation warning to the client itself, does every command also print that out (ie. if we add it to the client and the command does it do it twice?)

@ceciliastevens
Copy link
Contributor Author

ceciliastevens commented Mar 20, 2025

Have we tested this alongside the cli update? Do the py42 deprecations carry over to that?

If we add a deprecation warning to the client itself, does every command also print that out (ie. if we add it to the client and the command does it do it twice?)

Yes, the code42cli prints out warnings generated by its dependencies, including py42, so if we make these changes together both the SDK's warning and the CLI's warning will print (as do warnings from other dependencies, currently it looks like there's one that pandas is throwing).

@ceciliastevens
Copy link
Contributor Author

Have we tested this alongside the cli update? Do the py42 deprecations carry over to that?
If we add a deprecation warning to the client itself, does every command also print that out (ie. if we add it to the client and the command does it do it twice?)

Yes, the code42cli prints out warnings generated by its dependencies, including py42, so if we make these changes together both the SDK's warning and the CLI's warning will print (as do warnings from other dependencies, currently it looks like there's one that pandas is throwing).

I actually spoke too soon on this one. It was a specific choice in how I was doing the warnings for the alert queries that was causing this. I updated how that is done and now it's only warning once.

@ceciliastevens ceciliastevens merged commit c19b7e1 into main Mar 21, 2025
5 of 6 checks passed
@ceciliastevens ceciliastevens deleted the INTEG-2892/deprecate-v1 branch March 21, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants