Add configurable runtime fallback message patterns#2433
Add configurable runtime fallback message patterns#2433zengxiaolou wants to merge 2 commits intocode-yeongyu:devfrom
Conversation
|
All contributors have signed the CLA. Thank you! ✅ |
There was a problem hiding this comment.
No issues found across 9 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The PR safely introduces a new optional configuration for custom retry message patterns with appropriate regex handling, comprehensive tests, and no breaking changes to existing logic.
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
|
I have read the CLA Document and I hereby sign the CLA |
Review SummaryI've reviewed PR #2433 and verified the implementation. Verification Results
Implementation AnalysisWhat this PR adds:
Code quality observations:
Documentation:
RecommendationLGTM - This is a clean, well-structured addition that enables teams to handle provider-specific retry scenarios (like "no available accounts" messages) without code changes. The implementation follows existing patterns and maintains backward compatibility. Ready to merge. |
Summary
runtime_fallback.retry_on_message_patternsschema/config support so teams can define provider-specific retry text triggers without patching sourcesession.error,message.updated, andsession.statusflows while keeping default behavior unchangedValidation
Summary by cubic
Adds support for
runtime_fallback.retry_on_message_patternsso teams can trigger fallback on provider-specific messages (via regex), not just status codes. Patterns are applied acrosssession.error,message.updated, andsession.statusflows; defaults stay the same.runtime_fallback.retry_on_message_patterns: string[](regex strings), default[].isRetryableErrorandextractAutoRetrySignaland used by event and message update handlers.Written for commit b8c16ac. Summary will update on new commits.