fix(call-omo-agent): respect syncPollTimeoutMs config for sync polling#2404
Open
rluisr wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix(call-omo-agent): respect syncPollTimeoutMs config for sync polling#2404rluisr wants to merge 1 commit intocode-yeongyu:devfrom
rluisr wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
The call_omo_agent tool had a hardcoded 5-minute timeout (300000ms) for sync polling, causing timeouts with slower models like gpt-5.4 high. Now uses background_task.syncPollTimeoutMs from plugin config, matching the existing delegate-task behavior.
9f8fac3 to
471eec8
Compare
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Correctly threads syncPollTimeoutMs config to the poller while maintaining the existing 5-minute default, ensuring no behavioral regression for existing users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call_omo_agentsync polling timeout being hardcoded at 300000ms (5 minutes), causing timeouts with slower models like gpt-5.4 high/mediumbackground_task.syncPollTimeoutMsconfig to thecall_omo_agentpath, matching thedelegate-taskbehaviorChanges
src/tools/call-omo-agent/completion-poller.tstimeoutMsparameter towaitForCompletion, defaulting to 300000ms when unsetsrc/tools/call-omo-agent/sync-executor.tsExecuteSyncOptionstype, threadsyncPollTimeoutMsthrough towaitForCompletionsrc/tools/call-omo-agent/tools.tssyncPollTimeoutMsincreateCallOmoAgentfactory, pass toexecuteSyncsrc/plugin/tool-registry.tspluginConfig.background_task?.syncPollTimeoutMstocreateCallOmoAgentTesting
bun run typecheck bun testTo override:
Related Issues
Summary by cubic
Fixes
call_omo_agentsync polling to respectbackground_task.syncPollTimeoutMsinstead of a hardcoded 5 minutes, preventing timeouts with slower models. Matches the existingdelegate-taskbehavior.syncPollTimeoutMsfrom plugin config intocreateCallOmoAgent→executeSync→waitForCompletion.Written for commit 471eec8. Summary will update on new commits.