Skip to content

fix(call-omo-agent): respect syncPollTimeoutMs config for sync polling#2404

Open
rluisr wants to merge 1 commit intocode-yeongyu:devfrom
rluisr:fix/call-omo-agent-sync-poll-timeout-config
Open

fix(call-omo-agent): respect syncPollTimeoutMs config for sync polling#2404
rluisr wants to merge 1 commit intocode-yeongyu:devfrom
rluisr:fix/call-omo-agent-sync-poll-timeout-config

Conversation

@rluisr
Copy link
Contributor

@rluisr rluisr commented Mar 9, 2026

Summary

  • Fix call_omo_agent sync polling timeout being hardcoded at 300000ms (5 minutes), causing timeouts with slower models like gpt-5.4 high/medium
  • Propagate existing background_task.syncPollTimeoutMs config to the call_omo_agent path, matching the delegate-task behavior

Changes

File Change
src/tools/call-omo-agent/completion-poller.ts Add optional timeoutMs parameter to waitForCompletion, defaulting to 300000ms when unset
src/tools/call-omo-agent/sync-executor.ts Add ExecuteSyncOptions type, thread syncPollTimeoutMs through to waitForCompletion
src/tools/call-omo-agent/tools.ts Accept syncPollTimeoutMs in createCallOmoAgent factory, pass to executeSync
src/plugin/tool-registry.ts Pass pluginConfig.background_task?.syncPollTimeoutMs to createCallOmoAgent

Testing

bun run typecheck
bun test

To override:

// .opencode/oh-my-opencode.jsonc
{
  "background_task": {
    "syncPollTimeoutMs": 600000  // 10 min (minimum: 60000)
  }
}

Related Issues


Summary by cubic

Fixes call_omo_agent sync polling to respect background_task.syncPollTimeoutMs instead of a hardcoded 5 minutes, preventing timeouts with slower models. Matches the existing delegate-task behavior.

  • Bug Fixes
    • Threads syncPollTimeoutMs from plugin config into createCallOmoAgentexecuteSyncwaitForCompletion.
    • Uses the configured value; falls back to 300000 ms when unset.

Written for commit 471eec8. Summary will update on new commits.

The call_omo_agent tool had a hardcoded 5-minute timeout (300000ms) for
sync polling, causing timeouts with slower models like gpt-5.4 high.
Now uses background_task.syncPollTimeoutMs from plugin config, matching
the existing delegate-task behavior.
@rluisr rluisr force-pushed the fix/call-omo-agent-sync-poll-timeout-config branch from 9f8fac3 to 471eec8 Compare March 9, 2026 07:30
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Correctly threads syncPollTimeoutMs config to the poller while maintaining the existing 5-minute default, ensuring no behavioral regression for existing users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant