Skip to content

fix(skill-context): gate discovered browser skills by provider#2397

Merged
code-yeongyu merged 1 commit intodevfrom
fix/browser-provider-skill-context-playwright
Mar 11, 2026
Merged

fix(skill-context): gate discovered browser skills by provider#2397
code-yeongyu merged 1 commit intodevfrom
fix/browser-provider-skill-context-playwright

Conversation

@code-yeongyu
Copy link
Owner

@code-yeongyu code-yeongyu commented Mar 9, 2026

Summary

  • prevent discovered provider-gated browser skills from overriding the selected builtin browser provider in createSkillContext
  • add a regression test proving agent-browser no longer reintroduces a discovered playwright skill

Verification

  • bun test src/plugin/skill-context.test.ts src/features/opencode-skill-loader/skill-content.test.ts src/features/builtin-skills/skills.test.ts
  • bun run typecheck
  • bun run build
  • manual QA: loaded createSkillContext with browser_automation_engine.provider = "agent-browser" and a discovered .claude/skills/playwright; confirmed hasPlaywright: false and hasAgentBrowser: true

Summary by cubic

Fixes a bug where discovered browser skills could override the configured provider in createSkillContext. Only the skill matching browser_automation_engine.provider is included, preventing playwright from superseding agent-browser.

  • Bug Fixes
    • Gate provider-specific browser skills to the selected provider (agent-browser, playwright).
    • Filter discovered skills across all sources before merging to honor the configured provider.
    • Add a regression test verifying browser_automation_engine.provider = "agent-browser" ignores a discovered playwright skill.

Written for commit 1528e46. Summary will update on new commits.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: The fix correctly gates discovered browser skills to the configured provider using a safe filter and includes a regression test. No impact on non-browser skills.

@code-yeongyu code-yeongyu merged commit 70edea2 into dev Mar 11, 2026
8 checks passed
@code-yeongyu code-yeongyu deleted the fix/browser-provider-skill-context-playwright branch March 11, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant