fix(skill-context): gate discovered browser skills by provider#2397
Merged
code-yeongyu merged 1 commit intodevfrom Mar 11, 2026
Merged
fix(skill-context): gate discovered browser skills by provider#2397code-yeongyu merged 1 commit intodevfrom
code-yeongyu merged 1 commit intodevfrom
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The fix correctly gates discovered browser skills to the configured provider using a safe filter and includes a regression test. No impact on non-browser skills.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createSkillContextagent-browserno longer reintroduces a discoveredplaywrightskillVerification
bun test src/plugin/skill-context.test.ts src/features/opencode-skill-loader/skill-content.test.ts src/features/builtin-skills/skills.test.tsbun run typecheckbun run buildcreateSkillContextwithbrowser_automation_engine.provider = "agent-browser"and a discovered.claude/skills/playwright; confirmedhasPlaywright: falseandhasAgentBrowser: trueSummary by cubic
Fixes a bug where discovered browser skills could override the configured provider in
createSkillContext. Only the skill matchingbrowser_automation_engine.provideris included, preventingplaywrightfrom supersedingagent-browser.agent-browser,playwright).browser_automation_engine.provider = "agent-browser"ignores a discoveredplaywrightskill.Written for commit 1528e46. Summary will update on new commits.