Skip to content

fix: custom agent is invisible #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davincilll wants to merge 4 commits into
base: dev
Choose a base branch
from
+26 −15
Open

fix: custom agent is invisible #2392

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca8fe8d
fix: pass customAgentSummaries to createBuiltinAgents instead of ctx.…
davincilll Mar 8, 2026
5556634
Update src/plugin-handlers/agent-config-handler.ts
davincilll Mar 8, 2026
7204c52
fix(agent-config): remove redundant closing bracket and whitespace
davincilll Mar 9, 2026
d2fab67
refactor(agent-config): consolidate and enhance agent configuration l…
davincilll Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions src/plugin-handlers/agent-config-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,31 @@ export async function applyAgentConfig(params: {
const useTaskSystem = params.pluginConfig.experimental?.task_system ?? false;
const disableOmoEnv = params.pluginConfig.experimental?.disable_omo_env ?? false;

const includeClaudeAgents = params.pluginConfig.claude_code?.agents ?? true;
const userAgents = includeClaudeAgents ? loadUserAgents() : {};
const projectAgents = includeClaudeAgents ? loadProjectAgents(params.ctx.directory) : {};

const rawPluginAgents = params.pluginComponents.agents;
const pluginAgents = Object.fromEntries(
Object.entries(rawPluginAgents).map(([key, value]) => [
key,
value ? migrateAgentConfig(value as Record<string, unknown>) : value,
]),
);

const configAgent = params.config.agent as AgentConfigRecord | undefined;
const allAgentsForSummary = {
...configAgent,
...userAgents,
...projectAgents,
...pluginAgents,
};
const customAgentSummaries = Object.entries(allAgentsForSummary)
.filter(([, config]) => config != null)
.map(([name, config]) => ({
name,
description: (config as { description?: string }).description ?? "",
}));
const builtinAgents = await createBuiltinAgents(
migratedDisabledAgents,
params.pluginConfig.agents,
Expand All @@ -86,26 +111,14 @@ export async function applyAgentConfig(params: {
params.pluginConfig.categories,
params.pluginConfig.git_master,
allDiscoveredSkills,
params.ctx.client,
customAgentSummaries,
browserProvider,
currentModel,
disabledSkills,
useTaskSystem,
disableOmoEnv,
);

const includeClaudeAgents = params.pluginConfig.claude_code?.agents ?? true;
const userAgents = includeClaudeAgents ? loadUserAgents() : {};
const projectAgents = includeClaudeAgents ? loadProjectAgents(params.ctx.directory) : {};

const rawPluginAgents = params.pluginComponents.agents;
const pluginAgents = Object.fromEntries(
Object.entries(rawPluginAgents).map(([key, value]) => [
key,
value ? migrateAgentConfig(value as Record<string, unknown>) : value,
]),
);

const disabledAgentNames = new Set(
(migratedDisabledAgents ?? []).map(a => a.toLowerCase())
);
Expand All @@ -123,8 +136,6 @@ export async function applyAgentConfig(params: {
const shouldDemotePlan = plannerEnabled && replacePlan;
const configuredDefaultAgent = getConfiguredDefaultAgent(params.config);

const configAgent = params.config.agent as AgentConfigRecord | undefined;

if (isSisyphusEnabled && builtinAgents.sisyphus) {
if (configuredDefaultAgent) {
(params.config as { default_agent?: string }).default_agent =
Expand Down