Skip to content

Fix error in formula for deletion computation #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
louismartin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix error in formula for deletion computation #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions SARI.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ def SARIngram(sgrams, cgrams, rgramslist, numref):

# DELETION
delgramcounter_rep = sgramcounter_rep - cgramcounter_rep
delgramcountergood_rep = delgramcounter_rep - rgramcounter
delgramcounterall_rep = sgramcounter_rep - rgramcounter
delgramcountergood_rep = delgramcounter_rep & rgramcounterall_rep
deltmpscore1 = 0
deltmpscore2 = 0
for delgram in delgramcountergood_rep:
Expand All @@ -82,9 +82,11 @@ def SARIngram(sgrams, cgrams, rgramslist, numref):
delscore_precision = deltmpscore1 / len(delgramcounter_rep)
delscore_recall = 0
if len(delgramcounterall_rep) > 0:
delscore_recall = deltmpscore1 / len(delgramcounterall_rep)
# Deletions recall is not actually used for SARI (only deletions precision)
delscore_recall = deltmpscore2 / len(delgramcounterall_rep)
delscore = 0
if delscore_precision > 0 or delscore_recall > 0:
# This F1 is not actually used for SARI (only deletions precision)
delscore = 2 * delscore_precision * delscore_recall / (delscore_precision + delscore_recall)


Expand Down