Conversation
prek --verbose captures subprocess stdout via pipe. On Windows, the 4KB pipe buffer fills when pytest produces verbose output, causing a deadlock (pytest blocks writing, prek blocks waiting for exit). Split into two steps: prek --skip pytest for lint checks, and pytest running directly for streaming output. Also: - Add OSError catch in _pid_alive for Windows edge cases - Properly shut down daemon thread in test_daemon.py session fixture Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
On Windows, os.kill(pid, 0) raises SystemError when the target process has exited but its handle state is in transition (WinError 87). This corrupts CPython C exception state, causing subsequent built-in calls like time.monotonic() to also raise SystemError. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tion os.kill(pid, 0) on Windows corrupts CPython C-level exception state even after the raised OSError is caught. This causes subsequent calls to C built-ins (time.monotonic, time.sleep) to raise SystemError. Use ctypes OpenProcess instead, which is the proper Win32 API for checking process existence. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.