Add support for SafeByte and SafeBytes #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is no direct way to write a safe byte or a byte slice to a SafeWriter. They have to be type-casted to either a rune (for byte) or a string (for []byte). It would be more efficient to add the types (and helpers) SafeByte and SafeBytes. Also, UnsafeByte and UnsafeBytes already exist. So, introducing SafeByte and SafeBytes would also make the API more consistent.
Member
|
|
dhartunian
approved these changes
Jan 29, 2025
Contributor
dhartunian
left a comment
dhartunian
left a comment
There was a problem hiding this comment.
LGTM
You probably want to add a tag with the next release version so we can bump in CRDB. Given this is a backwards compatible change, I think v1.1.6 is fine.
Contributor
Author
|
@dhartunian TFTR! Re: backward compatibility, two new methods are added to Edit: I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no direct way to write a safe byte or a byte slice to a SafeWriter. They have to be type-casted to either a rune (for byte) or a string (for []byte). It would be more efficient to add the types (and helpers) SafeByte and SafeBytes.
Also, UnsafeByte and UnsafeBytes already exist. So, introducing SafeByte and SafeBytes would also make the API more consistent.
This change is