tests.html: Ignore CI infra failures for "Top failures" table, add graph for infra/harness failures #8643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `mypy` was clean, `pyright` had lots of complaints like > store-tests:90:41 - error: Argument of type "JsonValue" cannot be assigned to parameter "context" > of type "str" in function "is_valid_context": Type "JsonValue" is not assignable to type "str" which made the file look bad in vim. Use our `get_str()` JSON utility helper to properly narrow the types.
1. Add `<!DOCTYPE html>` to tell browsers to use Standards Mode instead of Quirks Mode 2. Fix document structure: DOCTYPE → <html> → <head> → <body> 3. Fix `charset="utf-8"` (standard format) 4. Add standard meta tags "title" and "viewport" (for responsive design) 5. Add lang="en" attribute to <html> tag for accessibility 6. Move script into `<body>`.
No API or visual changes.
Migrate code from the v2 to the to v4 API:
- Scales: Convert yAxes arrays to direct scale objects (yAxes[{id: "y"}] → y: {})
- Options: Move ticks.min/max to scale.min/max, scaleLabel to scale.title
- Plugins: Wrap legend config in plugins.legend (v3+ requirement)
- Datasets: Add labels to legend, add `tension` for smooth curves
- Canvas: Wrap in `position:relative` containers for proper responsive rendering
- Enable fill for stacked area charts with semi-transparent backgrounds
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This table tells us which tests are the most flaky ones and need work. But they also often fail due to infrastructure issues, in particular nested KVM QEMU boot failures. We will track this separately.
This will show us how bad the nested KVM problems are, and whether they get worse over time. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes our weather report more useful. In particular, I object to e.g. this failure being so high on the list.
For testing locally, you can grab the current test-results.db, download it into the bots checkout, run
python3 -m http.serverand look at http://localhost:8000/tests.html.The new graph in particular: