Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| <iframe | ||
| src="/tetris/index.html" | ||
| width="100%" |
There was a problem hiding this comment.
Prevent /tetris iframe from loading itself
The Astro page at /tetris renders an <iframe> whose src is /tetris/index.html. However the page itself builds to dist/tetris/index.html, and there is also a static copy of the game at public/tetris/index.html. As a result the iframe resolves to the same URL as the parent page, causing the page to recursively embed itself during astro dev, or to be overwritten by the static file during astro build so the Layout wrapper is never served. Either way, the intended outer layout and the embedded game cannot coexist. Point the iframe at a different public path (e.g. /tetris-game/index.html) or move the page under another route to avoid the collision.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ead5cbc3288324a156ad0903f904d8