Add TLS-aware Docker context resolution in coast-docker#64
Draft
agustif wants to merge 2 commits intocoast-guard:mainfrom
Draft
Add TLS-aware Docker context resolution in coast-docker#64agustif wants to merge 2 commits intocoast-guard:mainfrom
agustif wants to merge 2 commits intocoast-guard:mainfrom
Conversation
Honor Docker's documented precedence by letting DOCKER_CONTEXT override DOCKER_HOST, treating DOCKER_CONTEXT=default as the default local engine selection, and only consulting currentContext when neither env var is set. Keep the shared resolver wiring limited to local/context socket discovery. Refs: coast-guard#60 Co-authored-by: Codex <noreply@openai.com>
This was referenced Mar 12, 2026
agustif
force-pushed
the
af/docker-context-tls
branch
from
e7f294a to
0bef148
Compare
Extend `coast-docker::host` so context-driven Docker endpoints can resolve TLS transport from Docker context storage. Preserve explicit env-driven DOCKER_HOST / DOCKER_TLS_VERIFY / DOCKER_CERT_PATH behavior by continuing to defer that path to Bollard's env-aware defaults. Reject ssh:// contexts explicitly in this slice. Refs: coast-guard#63 Co-authored-by: Codex <noreply@openai.com>
agustif
force-pushed
the
af/docker-context-tls
branch
from
0bef148 to
01cc46f
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft follow-up for #63.
This PR adds TLS-aware Docker context resolution inside
coast-docker::hostonly.Important review note
This branch currently includes the resolver base from #61 plus the TLS follow-up on top of it.
I’m opening it now for visibility because the implementation is ready, but the intended review/merge order is still:
If #61 lands first, this branch can be rebased down to the TLS-only delta.
What changed
<TLSPath>/docker/{ca,cert,key}.pem<TLSPath>/{ca,cert,key}.pemunix:///npipe://-> socket pathtcp:///http://without TLS material -> HTTPtcp:///https://with TLS material -> TLSssh://-> explicit unsupported error in this sliceDOCKER_HOST/DOCKER_TLS_VERIFY/DOCKER_CERT_PATHbehavior is still delegated to Bollard defaultsScope
This PR does not change daemon or CLI behavior beyond what already consumes the shared resolver. It keeps all TLS handling inside
coast-docker::host.Validation
cargo test -p coast-docker --libcargo test -p coast-cli doctor:: -- --nocaptureOut of scope
coast-guardfrontend/build issuesRefs: #63