Skip to content

https://github.com/coagulant/django-whatever/issues/32#33

Open
drtyrsa wants to merge 8 commits intocoagulant:masterfrom
drtyrsa:master
Open

https://github.com/coagulant/django-whatever/issues/32#33
drtyrsa wants to merge 8 commits intocoagulant:masterfrom
drtyrsa:master

Conversation

@drtyrsa
Copy link

@drtyrsa drtyrsa commented Jun 2, 2012

  1. issues/32 fixed.
  2. Generators are used instead of lists where possible (in xunit.py and models.py only).
  3. '',join(...) is changed to u''.join(...) where possible (in xunit.py and models.py only).
  4. random.randint(0, total - 1) is replaced with random.randrange(total), just clearer and more sematically correct.
  5. Some whitspace is removed where is appropriate.

@coagulant
Copy link
Owner

Your changes don't pass the testsuite.
python tests/manage.py ... FAILED (failures=11, errors=19)

Test requirements are in /tests/requirements.pip

I'm planning to refactor it and put it on Travis this week.

@drtyrsa
Copy link
Author

drtyrsa commented Jun 4, 2012

Fixed now, all test are passed. BTW, isn't it a good idea to convert all the str things to unicode? Or should they remain byte strings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants