Drop all pages in B-Tree multi-page operations at once instead #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors B-Tree multi-page operations to write all modified pages atomically to the Write-Ahead Log (WAL) instead of dropping them individually. The key change is collecting all PinnedWritePage instances during split and merge operations in a dropped_page_latches vector, then calling cache.drop_write_pages() once at the end to flush them as a single MultiPageOperation.
Key Changes
- Added
dropped_page_latchesparameter threading through B-Tree split and merge operations - Modified all leaf and internal node split/merge/redistribution functions to collect modified pages
- Changed WAL write pattern from individual page drops to batched atomic writes via
drop_write_pages()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| storage/src/cache.rs | Fixed duplicate comment marker in documentation for drop_write_pages() |
| engine/src/b_tree.rs | Added dropped_page_latches vector to collect modified pages during splits and merges; threaded this parameter through all affected functions; added drop_write_pages() calls at operation completion points |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Polyphemus980
force-pushed
the
feat/multi-lock-drop-b-tree
branch
from
5189a77 to
0e0c00a
Compare
kTrzcinskii
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.