Fixed touch on android #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnlohr
reviewed
Apr 30, 2025
| switch(flags){ | ||
| case AMOTION_EVENT_ACTION_POINTER_UP: | ||
| case AMOTION_EVENT_ACTION_UP:{ | ||
| touch_is_down[pid] = 0; |
Member
There was a problem hiding this comment.
Please check the value of pid to make sure it doesn't overflow the array of touch_is_down
CNFGEGLDriver.c
Outdated
| HandleButton( x, y, id, 0 ); | ||
| case AMOTION_EVENT_ACTION_POINTER_DOWN: | ||
| case AMOTION_EVENT_ACTION_DOWN:{ | ||
| touch_is_down[id] = 1; |
Member
There was a problem hiding this comment.
Please check to make sure you don't overflow the array.
CNFGEGLDriver.c
Outdated
| HandleMotion( x, y, index ); | ||
| case AMOTION_EVENT_ACTION_MOVE:{ | ||
| int off = 0; //number of touches preceeding i that are not down | ||
| for(int i = 0; i-off < pointer_count && pid+i<10; i++){ |
Member
There was a problem hiding this comment.
Please use a #define for the number of touches.
Contributor
Author
|
like this? |
cnlohr
reviewed
May 1, 2025
| size_t pointerCount = AMotionEvent_getPointerCount(event); | ||
| int pointer_count = AMotionEvent_getPointerCount(event); | ||
| int32_t action = AMotionEvent_getAction(event); | ||
| int flags = action & AMOTION_EVENT_ACTION_MASK; |
Member
|
Yes, this looks great. Thank you for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.