fix: use urllib v4 #482

fengmk2 · 2026-01-20T13:17:10Z

Summary by CodeRabbit

Documentation
- Updated minimum Node.js version requirement to 20.x
- Simplified installation command examples
- Refreshed contributors section
Tests
- Enhanced error reporting in test assertions
Chores
- Updated urllib dependency to latest version
- Removed contributor management script

_{✏️ Tip: You can customize this high-level summary in your review settings.}

gemini-code-assist · 2026-01-20T13:17:25Z

Summary of Changes

Hello @fengmk2, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on upgrading the urllib dependency to its latest major version, which ensures the project benefits from the most recent improvements and maintains compatibility. Accompanying this core update are adjustments to the project's documentation, including an updated Node.js requirement and a more streamlined display of contributors. Additionally, minor improvements have been made to a test assertion for better diagnostic capabilities.

Highlights

Dependency Upgrade: The urllib dependency has been upgraded from version 3.0.3 to 4.9.0, aligning the project with the latest features and fixes of the library.
Node.js Requirement Update: The minimum required Node.js version in the README.md has been updated from 14.x to 20.x.
Documentation Streamlining: The README.md now uses a dynamic contributors badge instead of a manually generated list, and npm install commands have been shortened to npm i.
Build Script Refinement: The contributor script and the git-contributor dev dependency have been removed from package.json.
Test Assertion Improvement: An assertion in test/get.test.js has been enhanced to include the error message, providing more context for debugging failed tests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

coderabbitai · 2026-01-20T13:17:33Z

📝 Walkthrough

Walkthrough

This PR updates Node.js version requirements from 14.x to 20.x, upgrades the urllib dependency from 3.0.3 to 4.9.0, removes contributor-related tooling, standardizes npm commands to shorter syntax, and enhances test failure messaging for network errors.

Changes

Cohort / File(s)	Summary
Documentation & Configuration `README.md`, `package.json`	Updated minimum Node.js requirement to 20.x; replaced `npm install` commands with `npm i` syntax; upgraded urllib dependency from ^3.0.3 to ^4.9.0; removed git-contributor devDependency and contributor script; replaced Git contributor table with single image link
Test Suite `test/get.test.js`	Enhanced test assertion for network error cases (ENOTFOUND, Connect Timeout Error) to include error message as failure message for improved debugging output

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 From Node fourteen to twenty we hop with delight,
npm i makes our commands crisp and tight,
urllib springs forth with a version so new,
Contributors rest as tables turn blue,
Tests now speak clearer when errors appear—
A minor update that brings cheer! 🌟

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: use urllib v4' directly reflects the main change: updating the urllib dependency from v3.0.3 to v4.9.0, which is the primary modification across the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR upgrades the urllib dependency from version 3 to version 4 and makes related documentation updates. The changes align the Node.js version requirement with urllib v4's requirements and modernize the contributor attribution system.

Changes:

Upgraded urllib from ^3.0.3 to ^4.9.0
Updated Node.js requirement from 14.x to 20.x (consistent with package.json engines field)
Replaced git-contributor with contrib.rocks for displaying contributors

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
package.json	Updated urllib to v4.9.0, removed git-contributor dependency and script
test/get.test.js	Enhanced test assertion with error message output for better debugging
README.md	Updated Node.js version requirement to 20.x, simplified npm commands, replaced contributor section with contrib.rocks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

gemini-code-assist

Code Review

This pull request updates urllib to version 4, removes the git-contributor dependency, and updates related documentation. While the cleanup is good, the urllib upgrade introduces two issues. First, a breaking change in urllib's error handling for HTTP status codes is not addressed, which will alter the application's behavior. Second, a test case in test/get.test.js is now incorrect due to a change in urllib's error messages. I've provided comments with details and suggestions for both issues.

package.json

gemini-code-assist · 2026-01-20T13:20:24Z

test/get.test.js

      const headers = options.headers;
      assert(headers.Authorization);
-      assert(err.message.includes('ENOTFOUND') || err.message.includes('Connect Timeout Error'));
+      assert(err.message.includes('ENOTFOUND') || err.message.includes('Connect Timeout Error'), err.message);


With the upgrade to urllib v4, the timeout error message has changed. The new message format is Connect timeout for ${timeout}ms, whereas the previous version used Connect Timeout Error, ${timeout}ms....

This assertion will likely fail for timeout scenarios. Please update it to reflect the new error message.

Suggested change

assert(err.message.includes('ENOTFOUND') || err.message.includes('Connect Timeout Error'), err.message);

assert(err.message.includes('ENOTFOUND') || err.message.includes('Connect timeout'), err.message);

[skip ci] ## <small>8.0.1 (2026-01-20)</small> * fix: use urllib v4 (#482) ([fef57f7](fef57f7)), closes [#482](#482) [hi#level](https://github.com/hi/issues/level) * chore: Configure Renovate (#483) ([6d126a6](6d126a6)), closes [#483](#483) * chore(deps): update actions/checkout action to v6 (#485) ([0bb0fd3](0bb0fd3)), closes [#485](#485) * chore(deps): update microsoft/setup-msbuild action to v1.3.3 (#484) ([284b919](284b919)), closes [#484](#484)

github-actions · 2026-01-20T13:58:22Z

🎉 This PR is included in version 8.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

fix: use urllib v4

d9ae720

fengmk2 requested a review from Copilot January 20, 2026 13:17

Copilot started reviewing on behalf of fengmk2 January 20, 2026 13:17 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

gemini-code-assist bot reviewed Jan 20, 2026

View reviewed changes

fengmk2 mentioned this pull request Jan 20, 2026

[Snyk] Security upgrade urllib from 3.27.3 to 4.0.0 #480

Closed

fengmk2 merged commit fef57f7 into master Jan 20, 2026
17 of 18 checks passed

fengmk2 deleted the use-urllib-v4 branch January 20, 2026 13:52

github-actions bot added the released label Jan 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use urllib v4 #482

fix: use urllib v4 #482

fengmk2 commented Jan 20, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

gemini-code-assist bot commented Jan 20, 2026

Uh oh!

coderabbitai bot commented Jan 20, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot Jan 20, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	assert(err.message.includes('ENOTFOUND') \|\| err.message.includes('Connect Timeout Error'), err.message);
	assert(err.message.includes('ENOTFOUND') \|\| err.message.includes('Connect timeout'), err.message);

fix: use urllib v4 #482

fix: use urllib v4 #482

Conversation

fengmk2 commented Jan 20, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

gemini-code-assist bot commented Jan 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

coderabbitai bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fengmk2 commented Jan 20, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 20, 2026 •

edited

Loading