fixed an issue with libxl_set_vcpuaffinity() on newer xen versions#17
Open
marc-werner wants to merge 1 commit intocnplab:masterfrom
Open
fixed an issue with libxl_set_vcpuaffinity() on newer xen versions#17marc-werner wants to merge 1 commit intocnplab:masterfrom
marc-werner wants to merge 1 commit intocnplab:masterfrom
Conversation
Contributor
|
Hi, Thanks a lot for the patch! I tested and it looks good. I just have two small nits: 1) commit short message is too long and is missing the module it affects (in the case domain/xl). Could be something similar too "domain/xl: import vcpuaffinity macro from libvirt" (as an example). 2) to include the description that you have in this pull request in the commit below the short message. |
This patch includes a macro from libvirt to fix issues with libxl_set_vcpuaffinity() that arise with newer xen versions. Beginning with version 4.5 the functions requires an additional parameter for 'VCPU soft affinity' that cosmos does not use anyway. The macro is taken from linvirt. See https://gitlab.com/libvirt/libvirt/commit/bfc72e99920215c9b004a5380ca61fe6ff81ea6b for more details.
Author
|
Hi, I fixed the commit message. Please check if it suits your requirements. Regards, Marc |
Contributor
|
Looks good! But I guess the PR wasn't updated correctly. |
marc-werner
force-pushed
the
master
branch
2 times, most recently
from
0e2e2b4 to
c4bbaaa
Compare
Author
|
Sorry for the delay. Please check the pull request again. Regards, Marc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch includes a macro from libvirt to fix issues with libxl_set_vcpuaffinity() that arise with newer xen versions. Beginning with version 4.5 the functions requires an additional parameter for 'VCPU soft affinity' that cosmos does not use anyway.
The macro is taken from linvirt. See https://gitlab.com/libvirt/libvirt/commit/bfc72e99920215c9b004a5380ca61fe6ff81ea6b for more details.