Skip to content

Merge RVDSS integration tests into main indicator branch #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nmdefries merged 18 commits into from
Dec 19, 2025
Merged

Merge RVDSS integration tests into main indicator branch #1700

nmdefries merged 18 commits into from
Dec 19, 2025

Conversation

@cchuong
Copy link
Collaborator

@cchuong cchuong commented Dec 18, 2025 •
edited
Loading

addresses issue(s) #ISSUE

Summary:

  • Add integration tests (acquisition and server) updating and querying the database
  • Change time_type and issue to integers instead of dates
  • Update documentation + code to expect a single large table instead of 3 subtables
  • Add endpoint code
  • Fix update function to take a list of dicts instead of tuples

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

nmdefries and others added 17 commits August 28, 2025 17:58
@nmdefries
add RVDSS endpoint and python client support
9368b63
@nmdefries
review feedback. simplify and clean up rvdss server code
7b70f5f
@nmdefries
export rvdss endpoint
35f04ea
@nmdefries
update actions/cache version
7de9698
@cchuong
Merge branch 'ndefries/rvdss-endpoint' into rvdss-integration-tests
f137320
@cchuong
add integration test skeletons
9483093
@nmdefries
move alias to variable
924e788
@nmdefries
remove not null constraint from val columns and switch time_value and…
704bde0 
… issue to int8
@nmdefries
typo in fake credentials
68f1735
@nmdefries
switch rvdss to filter on epiweek col instead of time_value
79f7429
@cchuong
change tests and percent positive to floats and reorder columns
9fc8343
@cchuong
Change issue and time_value to integers instead of dates, and updated…
61a199a 
… tests
@cchuong
change data to dict and update integration tests
41b6fc7
@nmdefries
fix integration test connection mock
6b272b6
@cchuong
replace nan with None to match expected output
a12f696
@nmdefries
replace nans with Nones. reset_index to get index cols into SQL
9c07c8a
@cchuong
Add tests requesting lists and single values of parameters
9425d52
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 18, 2025
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 19, 2025 •
edited
Loading

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@nmdefries nmdefries self-requested a review December 19, 2025 20:08
nmdefries
nmdefries approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do a full review on the add_rvdss_indicator PR, since that one has out of date code anyway.

@nmdefries nmdefries merged commit a40b3ee into add_rvdss_indicator Dec 19, 2025
6 of 8 checks passed
@nmdefries nmdefries deleted the rvdss-integration-tests branch December 19, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmdefries nmdefries nmdefries approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cchuong @nmdefries