Skip to content

Project 2 PR#4

Open
nkrishnan19 wants to merge 1 commit intomainfrom
branch1
Open

Project 2 PR#4
nkrishnan19 wants to merge 1 commit intomainfrom
branch1

Conversation

@nkrishnan19
Copy link
Contributor

@nkrishnan19 nkrishnan19 commented Jan 5, 2023

Summary

In this PR, I have included my contribution to be reviewed for Project 2!

Motivation

By creating this PR, students can review, approve, and link this PR to their issue.

Testing

No testing required

@nkrishnan19 nkrishnan19 requested review from sagars729 and removed request for sagars729 January 5, 2023 01:34
@nate-perry nate-perry self-requested a review January 5, 2023 17:42
@nate-perry nate-perry self-requested a review January 5, 2023 17:44
nate-perry
nate-perry approved these changes Jan 5, 2023
View reviewed changes
Copy link

@nate-perry nate-perry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to go!

@nate-perry nate-perry linked an issue Jan 5, 2023 that may be closed by this pull request
Nathan Perry - First Card #12
Open
@xdward xdward self-requested a review January 5, 2023 18:39
xdward
xdward approved these changes Jan 5, 2023
View reviewed changes
Copy link

@xdward xdward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xdward xdward linked an issue Jan 5, 2023 that may be closed by this pull request
Edward Clavijo - First Card #13
Closed
@whe1123 whe1123 self-requested a review January 5, 2023 20:25
@ghost ghost assigned ghost and unassigned ghost Jan 5, 2023
whe1123
whe1123 approved these changes Jan 5, 2023
View reviewed changes
Copy link

@whe1123 whe1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes and it looks good!

@ghost ghost requested review from a user and whe1123 and removed request for a user January 5, 2023 20:29
@whe1123 whe1123 mentioned this pull request Jan 5, 2023
Open
@ghost ghost assigned ghost and unassigned ghost Jan 5, 2023
@whe1123 whe1123 mentioned this pull request Jan 5, 2023
Closed
@whe1123 whe1123 linked an issue Jan 5, 2023 that may be closed by this pull request
William He - First Card #14
Open
@jan29patel jan29patel self-requested a review January 5, 2023 20:51
jan29patel
jan29patel approved these changes Jan 5, 2023
View reviewed changes
Copy link

@jan29patel jan29patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

whe1123
whe1123 approved these changes Jan 5, 2023
View reviewed changes
Copy link

@whe1123 whe1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@FernandoGV667 FernandoGV667 self-assigned this Jan 5, 2023
@FernandoGV667 FernandoGV667 self-requested a review January 5, 2023 21:06
@FernandoGV667 FernandoGV667 removed their assignment Jan 5, 2023
FernandoGV667
FernandoGV667 approved these changes Jan 5, 2023
View reviewed changes
Copy link

@FernandoGV667 FernandoGV667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is OK

@FernandoGV667 FernandoGV667 linked an issue Jan 5, 2023 that may be closed by this pull request
Fernando Gonzales-Vigil - First Card #19
Closed
@amanthanvi amanthanvi self-requested a review January 5, 2023 21:44
amanthanvi
amanthanvi approved these changes Jan 5, 2023
View reviewed changes
Copy link

@amanthanvi amanthanvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aman Thanvi's change for a PR

@amanthanvi amanthanvi mentioned this pull request Jan 5, 2023
Open
@Sonia-Sandler Sonia-Sandler self-requested a review January 5, 2023 22:15
Sonia-Sandler
Sonia-Sandler approved these changes Jan 5, 2023
View reviewed changes
Copy link

@Sonia-Sandler Sonia-Sandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@Sonia-Sandler Sonia-Sandler linked an issue Jan 5, 2023 that may be closed by this pull request
Sonia Sandler - First Card #21
Open
@tara010101 tara010101 self-requested a review January 6, 2023 03:01
tara010101
tara010101 reviewed Jan 6, 2023
View reviewed changes
Copy link

@tara010101 tara010101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was reviewed and looks good!

@tara010101 tara010101 linked an issue Jan 6, 2023 that may be closed by this pull request
Tara Choudhary - First Card #27
Open
@sukhmank11 sukhmank11 assigned sukhmank11 and unassigned sukhmank11 Jan 6, 2023
@sukhmank11 sukhmank11 self-requested a review January 6, 2023 05:01
sukhmank11
sukhmank11 approved these changes Jan 6, 2023
View reviewed changes
Copy link

@sukhmank11 sukhmank11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This README looks good to me!

@sukhmank11 sukhmank11 linked an issue Jan 6, 2023 that may be closed by this pull request
Sukhman Kaur - First Card #29
Open
@anshvnm anshvnm requested review from anshvnm and removed request for anshvnm January 6, 2023 06:46
@JonathanGong5 JonathanGong5 self-requested a review January 6, 2023 18:27
JonathanGong5
JonathanGong5 approved these changes Jan 6, 2023
View reviewed changes
Copy link

@JonathanGong5 JonathanGong5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JonathanGong5 JonathanGong5 linked an issue Jan 6, 2023 that may be closed by this pull request
Jonathan Gong - First Card #33
Open
@peterhwangph peterhwangph self-requested a review January 7, 2023 01:22
peterhwangph
peterhwangph reviewed Jan 7, 2023
View reviewed changes
Copy link

@peterhwangph peterhwangph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@peterhwangph peterhwangph linked an issue Jan 7, 2023 that may be closed by this pull request
Peter Hwang - First Card #41
Open
peterhwangph
peterhwangph approved these changes Jan 7, 2023
View reviewed changes
Copy link

@peterhwangph peterhwangph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@arshiv27 arshiv27 self-requested a review January 10, 2023 04:56
arshiv27
arshiv27 approved these changes Jan 10, 2023
View reviewed changes
Copy link

@arshiv27 arshiv27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FernandoGV667 FernandoGV667 FernandoGV667 approved these changes

@tara010101 tara010101 tara010101 approved these changes

@sukhmank11 sukhmank11 sukhmank11 approved these changes

@arshiv27 arshiv27 arshiv27 approved these changes

@JonathanGong5 JonathanGong5 JonathanGong5 approved these changes

@jan29patel jan29patel jan29patel approved these changes

@whe1123 whe1123 whe1123 approved these changes

@Sonia-Sandler Sonia-Sandler Sonia-Sandler approved these changes

+4 more reviewers

@amanthanvi amanthanvi amanthanvi approved these changes

@nate-perry nate-perry nate-perry approved these changes

@peterhwangph peterhwangph peterhwangph approved these changes

@xdward xdward xdward approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone