EXOnanoAODv1 producers and setup #48502

kerstinlovisa · 2025-07-08T15:25:31Z

PR description:

This PR includes producers and setup for a first version of EXO PAG customizations of nanoAOD, with customization combined from multiple analysis teams working with long-lived particles, including:

Displaced muons
Displaced electrons
Displaced jets (with leptons)
Muon detector showers
Displaced taus

Previously discussed at the nanoAOD deep dive, within XPOG April 2 2025 and July 9 2025, and within EXO at the EXO workshop and general meeting.

The PR depends on cms-data/RecoTauTag-TrainingFiles#15 PR with training data for the displaced tau tag.

PR validation:

Collections with number of variables and sizes for different datasets has been evaluated:

Timing study done for running AOD -> EXOnanoAODv1 in one step tested on one file from TTto4Q MC dataset, accounting for differences on different machines. The study shows the relative time difference between producing standard nanoAOD and EXOnanoAODv1 as a function of number of events, with less than a factor 2 relative time increase.

The test script PhysicsTools/NanoAOD/test/test-exoNano.sh runs CMS driver command for AOD->EXOnanoAODv1 in one step (with --step PAT,NANO:(at)EXO) and works for this setup.

@enibigir @jniedzie

cmsbuild · 2025-07-08T15:25:59Z

cms-bot internal usage

cmsbuild · 2025-07-08T15:27:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48502/45439

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): Introduce L1ScoutingNanoAOD for Run3 #48163
- File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): Introduce L1ScoutingNanoAOD for Run3 #48163

cmsbuild · 2025-07-09T08:19:58Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48502/45445

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): Introduce L1ScoutingNanoAOD for Run3 #48163
- File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): Introduce L1ScoutingNanoAOD for Run3 #48163

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48502/45445/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48502/45445/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2025-07-09T08:24:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48502/45446

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): Introduce L1ScoutingNanoAOD for Run3 #48163
- File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): Introduce L1ScoutingNanoAOD for Run3 #48163

cmsbuild · 2025-07-09T08:25:03Z

Pull request #48502 was updated.

ftorrresd · 2025-07-09T11:55:10Z

enable nano

ftorrresd · 2025-07-09T11:55:16Z

please test

cmsbuild · 2025-07-09T12:05:55Z

-1

Failed Tests: Build ClangBuild
Size: This PR adds an extra 80KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f12b81/47149/summary.html
COMMIT: 7a9ef1f
CMSSW: CMSSW_15_1_X_2025-07-09-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48502/47149/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

ftorrresd · 2025-12-13T13:04:02Z

please test

cmsbuild · 2025-12-13T14:46:46Z

-1

Failed Tests: RelVals-NANO
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f12b81/49953/summary.html
COMMIT: c51bf4e
CMSSW: CMSSW_16_0_X_2025-12-13-1100/el8_amd64_gcc13
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48502/49953/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals-NANO

2500.3212500.321_EXONANOmc150X/step2_EXONANOmc150X.log
2500.33112500.3311_EXONANOdata150Xrun3/step2_EXONANOdata150Xrun3.log

Comparison Summary

Summary:

You potentially added 3 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 5 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4273241
DQMHistoTests: Total failures: 26
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4273195
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

kerstinlovisa · 2025-12-15T09:29:29Z

The tests failed because the displaced tau training data is not yet merged in cms-data. Should we merge that PR first or can we test this PR together with cms-data/RecoTauTag-TrainingFiles#15?

AdrianoDee · 2025-12-15T09:39:25Z

please test with cms-data/RecoTauTag-TrainingFiles#15

AdrianoDee · 2025-12-15T09:41:03Z

@kerstinlovisa I've sent the test with cms-data/RecoTauTag-TrainingFiles#15, but note that the tests there were failing. So there may be something you need to act on.

cmsbuild · 2025-12-15T13:22:29Z

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f12b81/49974/summary.html
COMMIT: c51bf4e
CMSSW: CMSSW_16_0_X_2025-12-14-2300/el8_amd64_gcc13
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48502/49974/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f12b81/49974/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f12b81/49974/git-merge-result

Failed RelVals-INPUT

2500.3212500.321_EXONANOmc150X/step2_EXONANOmc150X.log
2500.33112500.3311_EXONANOdata150Xrun3/step2_EXONANOdata150Xrun3.log

Comparison Summary

Summary:

You potentially added 11 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4271963
DQMHistoTests: Total failures: 11604
DQMHistoTests: Total nulls: 145
DQMHistoTests: Total successes: 4260194
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 42696.130000000005 KiB( 52 files compared)
DQMHistoSizes: changed ( 10224.0,... ): 6.566 KiB Vertexing/PrimaryVertexV
DQMHistoSizes: changed ( 16834.0,... ): 5613.913 KiB HLT/Vertexing
DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 34434.0,... ): 3336.274 KiB HLT/Vertexing
DQMHistoSizes: changed ( 34434.0,... ): 9.842 KiB Vertexing/PrimaryVertexV
DQMHistoSizes: changed ( 34434.0,... ): 5.820 KiB MTD/Vertices
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: found differences in 10 / 51 workflows

makortel · 2025-12-17T20:01:48Z

PhysicsTools/NanoAOD/plugins/DisTauTag.cc

+    if (!boost::filesystem::is_regular_file(graphPath_)) {
+      throw std::runtime_error("DisTauTag model not found: " + graphPath_);


It would be better to use edm::FileInPath (already as the type of the graphPath configuration parameter), see
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideEdmFileInPath
https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideAboutPythonConfigFile

Then the file would be found also with patch releases or when running cmsRun in other directory than $CMSSW_BASE/src.

makortel · 2025-12-17T20:02:19Z

PhysicsTools/NanoAOD/plugins/DisTauTag.cc

+}
+
+void DisTauTag::initializeTensorFlow() const {
+  std::lock_guard<std::mutex> lock(session_mutex_);


This mutex must be avoided.

makortel

The mutex must be avoided. These comments give a direction how that could be done.

makortel · 2025-12-17T20:03:59Z

PhysicsTools/NanoAOD/plugins/DisTauTag.cc

+  std::vector<float> v_score1(jets_size, -9);
+
+  if (!session_) {
+    initializeTensorFlow();


Can initializeTensorFlow() be called from the constructor? Then the mutex would not be needed for that case.

makortel · 2025-12-17T20:04:41Z

PhysicsTools/NanoAOD/plugins/DisTauTag.cc

+      std::lock_guard<std::mutex> lock(session_mutex_);
+      tensorflow::run(session_, {{"input_1", input_1}, {"input_2", input_2}}, {"final_out"}, &outputs);


tensorflow::run() is thread safe, so the lock is not needed.

makortel · 2025-12-17T20:06:00Z

PhysicsTools/NanoAOD/plugins/DisTauTag.cc

+}
+
+void DisTauTag::cleanupTensorFlow() {
+  std::lock_guard<std::mutex> lock(session_mutex_);


The lock is not needed here. That would be more clear if the content of this function would be moved to the destructor (there is no way a destructor could be called concurrently).

makortel

Some further suggestions for some simplification opportunities that caught my eye (for your consideration).

makortel · 2025-12-17T20:13:03Z

PhysicsTools/NanoAOD/interface/DisTauTagScaling.h

@@ -0,0 +1,191 @@
+namespace Scaling {


Namespaces should start with lower case letter (see 2.7 in https://cms-sw.github.io/cms_coding_rules.html)

Also the include guard is missing (4.1 in https://cms-sw.github.io/cms_coding_rules.html)

makortel · 2025-12-17T20:14:40Z

PhysicsTools/NanoAOD/interface/DisTauTagScaling.h

+  };
+};  // namespace Scaling
+
+namespace Setup {


Setup is a very common name (that should start with lower case), so there is a risk for name collisions.

makortel · 2025-12-17T20:17:37Z

PhysicsTools/NanoAOD/plugins/DSAMuonTableProducer.cc

+  edm::Handle<std::vector<reco::Track>> dsaMuonHandle;
+  iEvent.getByToken(dsaMuonTag_, dsaMuonHandle);
+  edm::Handle<std::vector<pat::Muon>> muonHandle;
+  iEvent.getByToken(muonTag_, muonHandle);


Seems like these could be

Suggested change

edm::Handle<std::vector<reco::Track>> dsaMuonHandle;

iEvent.getByToken(dsaMuonTag_, dsaMuonHandle);

edm::Handle<std::vector<pat::Muon>> muonHandle;

iEvent.getByToken(muonTag_, muonHandle);

const std::vector<reco::Track>& dsaMuon = iEvent.get(dsaMuonTag_);

const std::vector<pat::Muon>& muonHandle = iEvent.get(muonTag_);

same for the other Handle+getByToken() pairs (while they work, this suggestion would be less code and tiny bit faster by avoiding the checks in Handle de-references).

makortel · 2025-12-17T20:18:14Z

PhysicsTools/NanoAOD/plugins/DSAMuonTableProducer.cc

+  GlobalPoint beamSpot(bs.x(), bs.y(), bs.z());
+  reco::Vertex beamSpotVertex(beamSpotHandle->position(), beamSpotHandle->covariance3D());
+
+  edm::ESHandle<TransientTrackBuilder> builder = iSetup.getHandle(transientTrackBuilderToken_);


Could be

Suggested change

edm::ESHandle<TransientTrackBuilder> builder = iSetup.getHandle(transientTrackBuilderToken_);

const TransientTrackBuilder& builder = iSetup.getData(transientTrackBuilderToken_);

makortel · 2025-12-17T20:20:22Z

PhysicsTools/NanoAOD/plugins/DisTauTag.cc

+}
+
+void DisTauTag::produce(edm::StreamID, edm::Event& event, const edm::EventSetup& setup) const {
+  auto jets = getHandle(event, jets_token);


Seems like the Handle property is used, so this could be

Suggested change

auto jets = getHandle(event, jets_token);

auto jets = event.getHandle(jets_token);

after which the local getHandle() function is not needed anymore.

makortel · 2025-12-17T20:21:48Z

PhysicsTools/NanoAOD/plugins/DispJetTableProducer.cc

+  edm::EDGetTokenT<reco::VertexCollection> vtxTag_;
+  edm::EDGetTokenT<reco::VertexCollection> secVtxTag_;
+
+  const TransientTrackBuilder* theB;


theB seems to be used only inside the produce() function, so this data member does not seem to be needed.

makortel · 2025-12-17T20:22:25Z

PhysicsTools/NanoAOD/plugins/DispJetTableProducer.cc

+  ~DispJetTableProducer() override {}
+
+  void produce(edm::Event& iEvent, const edm::EventSetup& iSetup) override {
+    theB = &iSetup.getData(ttbToken_);


i.e.

Suggested change

theB = &iSetup.getData(ttbToken_);

const TransientTrackBuilder* theB = &iSetup.getData(ttbToken_);

or

Suggested change

theB = &iSetup.getData(ttbToken_);

const TransientTrackBuilder& theB = iSetup.getData(ttbToken_);

makortel · 2025-12-17T20:24:20Z

PhysicsTools/NanoAOD/plugins/DispJetTableProducer.cc

+    edm::Handle<std::vector<pat::Electron>> electronHandle;
+    iEvent.getByToken(electronTag_, electronHandle);
+
+    edm::Handle<std::vector<pat::Muon>> muonHandle;
+    iEvent.getByToken(muonTag_, muonHandle);
+
+    edm::Handle<reco::VertexCollection> primaryVertexHandle;
+    iEvent.getByToken(vtxTag_, primaryVertexHandle);
+
+    edm::Handle<reco::VertexCollection> secondaryVertexHandle;
+    iEvent.getByToken(secVtxTag_, secondaryVertexHandle);


Seems like these could be

Suggested change

edm::Handle<std::vector<pat::Electron>> electronHandle;

iEvent.getByToken(electronTag_, electronHandle);

edm::Handle<std::vector<pat::Muon>> muonHandle;

iEvent.getByToken(muonTag_, muonHandle);

edm::Handle<reco::VertexCollection> primaryVertexHandle;

iEvent.getByToken(vtxTag_, primaryVertexHandle);

edm::Handle<reco::VertexCollection> secondaryVertexHandle;

iEvent.getByToken(secVtxTag_, secondaryVertexHandle);

const std::vector<pat::Electron>& electrons = iEvent.get(electronTag_);

const std::vector<pat::Muon>& muons = iEvent.get(muonTag_);

const reco::VertexCollection& primaryVertex = iEvent.get(vtxTag_);

const reco::VertexCollection& secondaryVertex = iEvent.get(secVtxTag_);

makortel · 2025-12-17T20:25:57Z

PhysicsTools/NanoAOD/plugins/DispJetTableProducer.cc

+  std::vector<int> el_idx;
+  std::vector<bool> el_lIVF_match;
+  std::vector<int> el_IVF_df, el_IVF_ntracks, el_IVF_elid;
+  std::vector<float> el_IVF_x, el_IVF_y, el_IVF_z, el_IVF_cx, el_IVF_cy, el_IVF_cz, el_IVF_chi2, el_IVF_pt, el_IVF_eta,
+      el_IVF_phi, el_IVF_E, el_IVF_mass;
+  std::vector<int> el_IVF_trackcharge, el_IVF_trackelid, el_IVF_trackvtxid;
+  std::vector<float> el_IVF_trackpt, el_IVF_tracketa, el_IVF_trackphi, el_IVF_trackE, el_IVF_trackdxy, el_IVF_trackdz;
+  std::vector<float> el_IVF_tracksignedIP2D, el_IVF_tracksignedIP3D, el_IVF_tracksignedIP2Dsig,
+      el_IVF_tracksignedIP3Dsig;
+  std::vector<float> el_IVF_signedIP2D, el_IVF_signedIP3D, el_IVF_signedIP2Dsig, el_IVF_signedIP3Dsig;
+
+  std::vector<int> mu_idx;
+  std::vector<bool> mu_lIVF_match;
+  std::vector<int> mu_IVF_df, mu_IVF_ntracks, mu_IVF_muid;
+  std::vector<float> mu_IVF_x, mu_IVF_y, mu_IVF_z, mu_IVF_cx, mu_IVF_cy, mu_IVF_cz, mu_IVF_chi2, mu_IVF_pt, mu_IVF_eta,
+      mu_IVF_phi, mu_IVF_E, mu_IVF_mass;
+  std::vector<int> mu_IVF_trackcharge, mu_IVF_trackmuid, mu_IVF_trackvtxid;
+  std::vector<float> mu_IVF_trackpt, mu_IVF_tracketa, mu_IVF_trackphi, mu_IVF_trackE, mu_IVF_trackdxy, mu_IVF_trackdz;
+  std::vector<float> mu_IVF_tracksignedIP2D, mu_IVF_tracksignedIP3D, mu_IVF_tracksignedIP2Dsig,
+      mu_IVF_tracksignedIP3Dsig;
+  std::vector<float> mu_IVF_signedIP2D, mu_IVF_signedIP3D, mu_IVF_signedIP2Dsig, mu_IVF_signedIP3Dsig;


Could these be local variables in the produce() function? As data members they take memory throughout the job.

makortel · 2025-12-17T20:29:31Z

PhysicsTools/NanoAOD/plugins/ElectronExtendedTableProducer.cc

+  edm::Handle<double> rhoHandle;
+  iEvent.getByToken(rhoTag_, rhoHandle);
+  edm::Handle<std::vector<pat::Electron>> electrons;
+  iEvent.getByToken(electronTag_, electrons);
+  edm::Handle<reco::VertexCollection> primaryVertices;
+  iEvent.getByToken(vtxTag_, primaryVertices);
+  edm::Handle<std::vector<pat::Jet>> jetHandle;
+  iEvent.getByToken(jetTag_, jetHandle);
+  edm::Handle<std::vector<pat::Jet>> jetFatHandle;
+  iEvent.getByToken(jetFatTag_, jetFatHandle);
+  edm::Handle<std::vector<pat::Jet>> jetSubHandle;
+  iEvent.getByToken(jetSubTag_, jetSubHandle);


Seems like this could be

Suggested change

edm::Handle<double> rhoHandle;

iEvent.getByToken(rhoTag_, rhoHandle);

edm::Handle<std::vector<pat::Electron>> electrons;

iEvent.getByToken(electronTag_, electrons);

edm::Handle<reco::VertexCollection> primaryVertices;

iEvent.getByToken(vtxTag_, primaryVertices);

edm::Handle<std::vector<pat::Jet>> jetHandle;

iEvent.getByToken(jetTag_, jetHandle);

edm::Handle<std::vector<pat::Jet>> jetFatHandle;

iEvent.getByToken(jetFatTag_, jetFatHandle);

edm::Handle<std::vector<pat::Jet>> jetSubHandle;

iEvent.getByToken(jetSubTag_, jetSubHandle);

const double rho = iEvent.get(rhoTag_);

const std::vector<pat::Electron>& electrons = iEvent.get(electronTag_);

const reco::VertexCollection& primaryVertices = iEvent.get(vtxTag_);

edm::Handle<std::vector<pat::Jet>> jetHandle = iEvent.getHandle(jetTag_);

edm::Handle<std::vector<pat::Jet>> jetFatHandle = iEvent.getHandle(jetFatTag_);

edm::Handle<std::vector<pat::Jet>> jetSubHandle = iEvent.getHandle(jetSubTag_);

(also similarly elsewhere, but I stop commenting here)

makortel · 2025-12-17T20:34:13Z

Are the changes of this PR such that 100-200 MB memory increase would be expected? The max memory report in #48502 (comment) and cms-data/RecoTauTag-TrainingFiles#16 (comment) seem to suggest that, but the two tests report such increases in different workflows, that makes me wonder if the effect is real or if the magnitude of the "usual variations" has grown (#46966).

cmsbuild · 2025-12-18T12:59:29Z

Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X.

battibass

As promised, some review of the muon part from my side comes now, apologies for the belated action.

I will also have a look at the rest of the code in the coming days.

battibass · 2025-12-18T16:27:50Z

PhysicsTools/NanoAOD/plugins/DSAMuonTableProducer.cc

+  int getMatches(const pat::Muon& muon, const reco::Track& dsaMuon, float minPositionDiff = 1e-6) const;
+  int getDTMatches(const pat::Muon& muon, const reco::Track& dsaMuon, float minPositionDiff = 1e-6) const;
+  int getCSCMatches(const pat::Muon& muon, const reco::Track& dsaMuon, float minPositionDiff = 1e-6) const;


These three functions are essentially performing the same logic modulo minor differences. Such approach implies repeating almost-identical loops multiple times.

I would suggest writing a single function that accumulates on a struct containing three int reporting about all matches, DT matches and CSC matches, and returning the struct.

Also you could even store in the struct just two int if all matches is fully redundant.

battibass · 2025-12-18T16:28:31Z

PhysicsTools/NanoAOD/plugins/DSAMuonTableProducer.cc

+    pt.push_back(dsaMuon.pt());
+    ptErr.push_back(dsaMuon.ptError());
+    eta.push_back(dsaMuon.eta());
+    etaErr.push_back(dsaMuon.etaError());
+    phi.push_back(dsaMuon.phi());
+    phiErr.push_back(dsaMuon.phiError());
+    charge.push_back(dsaMuon.charge());
+    dxy.push_back(dsaMuon.dxy());
+    dz.push_back(dsaMuon.dz());
+    vx.push_back(dsaMuon.vx());
+    vy.push_back(dsaMuon.vy());
+    vz.push_back(dsaMuon.vz());
+    chi2.push_back(dsaMuon.chi2());
+    ndof.push_back(dsaMuon.ndof());
+
+    trkNumPlanes.push_back(dsaMuon.hitPattern().muonStationsWithValidHits());
+    trkNumHits.push_back(dsaMuon.hitPattern().numberOfValidMuonHits());
+    trkNumDTHits.push_back(dsaMuon.hitPattern().numberOfValidMuonDTHits());
+    trkNumCSCHits.push_back(dsaMuon.hitPattern().numberOfValidMuonCSCHits());
+    normChi2.push_back(dsaMuon.normalizedChi2());
+
+    outerEta.push_back(dsaMuon.extra().isNonnull() && dsaMuon.extra().isAvailable() ? dsaMuon.outerEta() : -999);
+    outerPhi.push_back(dsaMuon.extra().isNonnull() && dsaMuon.extra().isAvailable() ? dsaMuon.outerPhi() : -999);


Can't variables such as those ones be ntuplised using a SimpleTrackFlatTableProducer? If so, I would recommend using existing modules and configure them to extract the variables you need.

battibass · 2025-12-18T16:36:13Z

PhysicsTools/NanoAOD/plugins/MuonExtendedTableProducer.cc

+    innerTrackValidFraction.push_back((!muon.innerTrack().isNull()) ? muon.innerTrack()->validFraction() : -1);
+    globalTrackNormalizedChi2.push_back((!muon.globalTrack().isNull()) ? muon.globalTrack()->normalizedChi2() : -1);
+    CQChi2Position.push_back(muon.combinedQuality().chi2LocalPosition);
+    CQTrackKink.push_back(muon.combinedQuality().trkKink);
+    numberOfMatchedStation.push_back(muon.numberOfMatchedStations());
+    numberOfValidPixelHits.push_back(
+        (!muon.innerTrack().isNull()) ? muon.innerTrack()->hitPattern().numberOfValidPixelHits() : 0);
+    numberOfValidTrackerHits.push_back(
+        (!muon.innerTrack().isNull()) ? muon.innerTrack()->hitPattern().numberOfValidTrackerHits() : 0);


Also in this module, one can delegate the extraction of variables such as these ones to a simplePATMuonFlatTableProducer.

battibass · 2025-12-18T16:38:18Z

PhysicsTools/NanoAOD/plugins/SimpleFlatTableProducerPlugins.cc

 DEFINE_FWK_MODULE(SimpleTriggerTrackFlatTableProducer);
 DEFINE_FWK_MODULE(SimpleGsfTrackFlatTableProducer);
 DEFINE_FWK_MODULE(SimpleCompositeCandidateFlatTableProducer);
+DEFINE_FWK_MODULE(SimpleMuonRecHitClusterFlatTableProducer);


Is this ever used?

battibass · 2025-12-18T16:41:37Z

PhysicsTools/NanoAOD/plugins/DSAMuonTableProducer.cc

+  int getTotSegments(const reco::Track& dsaMuon) const;
+  int getDTSegments(const reco::Track& dsaMuon) const;
+  int getCSCSegments(const reco::Track& dsaMuon) const;


The same strategy proposed above could apply here as well

cmsbuild added this to the CMSSW_15_1_X milestone Jul 8, 2025

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending upgrade-pending code-checks-pending xpog-pending labels Jul 8, 2025

cmsbuild added code-checks-approved code-checks-pending and removed code-checks-pending code-checks-approved labels Jul 8, 2025

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Jul 9, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 9, 2025

cmsbuild added tests-started and removed tests-pending labels Jul 9, 2025

cmsbuild added tests-rejected and removed tests-started labels Jul 9, 2025

cmsbuild added tests-started and removed tests-pending labels Dec 13, 2025

cmsbuild added tests-rejected and removed tests-started labels Dec 13, 2025

cmsbuild added requires-external tests-started and removed tests-rejected labels Dec 15, 2025

cmsbuild added tests-rejected and removed tests-started labels Dec 15, 2025

jfernan2 mentioned this pull request Dec 17, 2025

Add DisplacedTauId training files cms-data/RecoTauTag-TrainingFiles#16

Open

makortel reviewed Dec 17, 2025

View reviewed changes

cmsbuild modified the milestones: CMSSW_16_0_X, CMSSW_16_1_X Dec 18, 2025

battibass reviewed Dec 18, 2025

View reviewed changes

		if (!boost::filesystem::is_regular_file(graphPath_)) {
		throw std::runtime_error("DisTauTag model not found: " + graphPath_);

		std::lock_guard<std::mutex> lock(session_mutex_);
		tensorflow::run(session_, {{"input_1", input_1}, {"input_2", input_2}}, {"final_out"}, &outputs);

	edm::ESHandle<TransientTrackBuilder> builder = iSetup.getHandle(transientTrackBuilderToken_);
	const TransientTrackBuilder& builder = iSetup.getData(transientTrackBuilderToken_);

	auto jets = getHandle(event, jets_token);
	auto jets = event.getHandle(jets_token);

	theB = &iSetup.getData(ttbToken_);
	const TransientTrackBuilder* theB = &iSetup.getData(ttbToken_);

	theB = &iSetup.getData(ttbToken_);
	const TransientTrackBuilder& theB = iSetup.getData(ttbToken_);

EXOnanoAODv1 producers and setup #48502

Are you sure you want to change the base?

EXOnanoAODv1 producers and setup #48502

Conversation

kerstinlovisa commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jul 8, 2025

Uh oh!

cmsbuild commented Jul 9, 2025

Uh oh!

cmsbuild commented Jul 9, 2025

Uh oh!

cmsbuild commented Jul 9, 2025

Uh oh!

ftorrresd commented Jul 9, 2025

Uh oh!

ftorrresd commented Jul 9, 2025

Uh oh!

cmsbuild commented Jul 9, 2025

Build

Clang Build

Uh oh!

ftorrresd commented Dec 13, 2025

Uh oh!

cmsbuild commented Dec 13, 2025

Failed RelVals-NANO

Comparison Summary

Uh oh!

kerstinlovisa commented Dec 15, 2025

Uh oh!

AdrianoDee commented Dec 15, 2025

Uh oh!

AdrianoDee commented Dec 15, 2025

Uh oh!

cmsbuild commented Dec 15, 2025

Failed RelVals-INPUT

Comparison Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

makortel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

makortel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kerstinlovisa commented Jul 8, 2025 •

edited

Loading

cmsbuild commented Jul 8, 2025 •

edited

Loading

battibass Dec 18, 2025 •

edited

Loading