Skip to content

Update tensorflow v2.12.0 to build OneDNN objects with -fno-omit-frame-pointer #9739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gartung wants to merge 7 commits into from
Closed

Update tensorflow v2.12.0 to build OneDNN objects with -fno-omit-frame-pointer #9739

gartung wants to merge 7 commits into from

Conversation

@gartung
Copy link
Member

@gartung gartung commented Mar 7, 2025 •
edited
Loading

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2025

A new Pull Request was created by @gartung for branch IB/CMSSW_15_1_X/master.

@iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5090b8/44855/summary.html
COMMIT: 8dd7015
CMSSW: CMSSW_15_1_X_2025-03-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9739/44855/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5090b8/44855/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5090b8/44855/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 42 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920287
  • DQMHistoTests: Total failures: 96
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920171
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.08000000000000002 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 145.014,... ): 0.008 KiB HLT/Filters
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@gartung gartung mentioned this pull request Mar 8, 2025
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 10, 2025

Pull request #9739 was updated.

@gartung gartung changed the title Build v2.12.0 with patch for stack unwind Build v2.12.0 with memory debug Mar 10, 2025
@gartung
Copy link
Member Author

gartung commented Mar 10, 2025

enable profiling

@gartung
Copy link
Member Author

gartung commented Mar 10, 2025

please test with cms-sw/cms-bot#2449

@gartung gartung changed the title Build v2.12.0 with memory debug Update v2.12.0 to commit with ONEDNN_ENABLE_MEM_DEBUG Mar 10, 2025
@gartung gartung changed the title Update v2.12.0 to commit with ONEDNN_ENABLE_MEM_DEBUG Update tensorflow v2.12.0 to commit with DNNL_ENABLE_MEM_DEBUG Mar 10, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 11, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5090b8/44895/summary.html
COMMIT: c0e90bb
CMSSW: CMSSW_15_1_X_2025-03-10-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9739/44895/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 176
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920104
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@gartung
Copy link
Member Author

gartung commented Mar 13, 2025

Closing because it prevents backtracking when segfault occurs because of canary values set to NAN.

@gartung gartung closed this Mar 13, 2025
@gartung gartung changed the title Update tensorflow v2.12.0 to commit with DNNL_ENABLE_MEM_DEBUG Update tensorflow v2.12.0 to build OneDNN objects with -fno-omit-frame-pointer Mar 17, 2025
@gartung
Copy link
Member Author

gartung commented Mar 17, 2025

@smuzaffar failures unrelated to this change
cms-sw/cmssw#47572 (comment)

@gartung gartung linked an issue Mar 17, 2025 that may be closed by this pull request
Compile OneDNN objects in Tensorflow build with -fno-omit-frame-pointer cms-sw/framework-team#1311
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5090b8/45014/summary.html
COMMIT: a36694d
CMSSW: CMSSW_15_1_X_2025-03-17-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9739/45014/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5090b8/45014/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5090b8/45014/git-merge-result

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2025

Pull request #9739 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5090b8/45043/summary.html
COMMIT: 864a0d3
CMSSW: CMSSW_15_1_X_2025-03-18-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9739/45043/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5090b8/45043/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5090b8/45043/git-merge-result

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 1807 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3927607
  • DQMHistoTests: Total failures: 275
  • DQMHistoTests: Total nulls: 80
  • DQMHistoTests: Total successes: 3927232
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 88.83000000000006 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 4.230 KiB Physics/NanoAODDQM
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2025

Pull request #9739 was updated.

@gartung gartung closed this Mar 19, 2025
@gartung gartung deleted the IB/CMSSW_15_1_X/master-pg branch March 19, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

externals-pending orp-pending pending-signatures tests-pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compile OneDNN objects in Tensorflow build with -fno-omit-frame-pointer

2 participants

@gartung @cmsbuild