Skip to content

Conversation

@ikrommyd
Copy link
Contributor

@ikrommyd ikrommyd commented Oct 26, 2025

Closes #297

@nsmith-
Copy link
Collaborator

nsmith- commented Oct 27, 2025

Can you add pyproject.toml to the watched files to trigger the wheel test at: https://github.com/cms-nanoAOD/correctionlib/blob/master/.github/workflows/wheels.yml#L10 ?
I want to see if cibw is happy with the changes there

@ikrommyd
Copy link
Contributor Author

@nsmith- I see build failure for 314t but given #284, I see that we should be skipping free-threaded builds atm.

@ikrommyd ikrommyd changed the title Support python3.14 and drop python3.8 build: support python3.14 and drop python3.8 Oct 27, 2025
Copy link
Collaborator

@nsmith- nsmith- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modernize as well!

@ikrommyd
Copy link
Contributor Author

Thanks for the modernize as well!

No worries! It would be nice to have a release with the cp314 wheels soon. Then numba just needs to make their pre-release an actual release and we got coffea working on cp314 without the need to compile anything. I don't know if you wanna merge do the free-threaded building first before a release though.

@nsmith- nsmith- added this pull request to the merge queue Oct 27, 2025
Merged via the queue into cms-nanoAOD:master with commit 122f3e5 Oct 27, 2025
18 checks passed
@nsmith-
Copy link
Collaborator

nsmith- commented Oct 27, 2025

I suppose #284 needs a rebase now. @lgray are you interested in doing that?
If it magically works now, maybe we can put it in. But it seemed to have issues

@ikrommyd ikrommyd deleted the add-py314-drop-py38 branch October 27, 2025 22:07
@lgray
Copy link
Contributor

lgray commented Oct 27, 2025

Sure no problem rebasing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

πthon wheels please?

3 participants