Skip to content

Fixes for minor typos#118

Merged
cmroche merged 6 commits intocmroche:masterfrom
namezys:small_fixes
Jan 10, 2026
Merged

Fixes for minor typos#118
cmroche merged 6 commits intocmroche:masterfrom
namezys:small_fixes

Conversation

@namezys
Copy link
Contributor

@namezys namezys commented May 4, 2025

Missing return

@codecov
Copy link

codecov bot commented May 4, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.65%. Comparing base (a72bfd3) to head (a0e3834).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
greeclimate/device.py 90.56% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   95.69%   95.65%   -0.04%     
==========================================
  Files           8        8              
  Lines         743      760      +17     
==========================================
+ Hits          711      727      +16     
- Misses         32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmroche cmroche self-requested a review January 10, 2026 17:47
…ng values

Added `Optional` return types to multiple property getters to gracefully handle missing or `None` values and ensure consistent behavior across device attributes.
# Conflicts:
#	greeclimate/device.py
@cmroche
Copy link
Owner

cmroche commented Jan 10, 2026

Thanks for the fix. This raised an oversight in the type hinting, and behaviour of other device properties, so I've extended the change to all of them including changing bool(...) properties to differentiate between false and None.

@cmroche cmroche merged commit b6004ea into cmroche:master Jan 10, 2026
9 of 11 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants