Add support for packet format used by Gree Pular#110
Closed
mlesniew wants to merge 1 commit intocmroche:masterfrom
Closed
Add support for packet format used by Gree Pular#110mlesniew wants to merge 1 commit intocmroche:masterfrom
mlesniew wants to merge 1 commit intocmroche:masterfrom
Conversation
Some Gree AC models, including the Gree Pular use a different format of the "res" packets, which are sent in response to commands. This commit extends the code to support this format without affecting the format used by other models.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 95.75% 95.75%
=======================================
Files 8 8
Lines 730 730
=======================================
Hits 699 699
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Feb 27, 2025
|
This fix appears to work for the Livo Gen 4 as well. Thanks! |
Owner
|
Thanks for the fix. I moved this to a new PR so I could rebase and check on the latest CI environment. It will be merged and release version posted at #132 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Gree AC models, including the Gree Pular use a different format of the "res" packets, which are sent in response to commands. This commit extends the code to support this format without affecting the format used by other models.