Skip to content

fix: invalid device state after bind#100

Merged
cmroche merged 3 commits intomasterfrom
fix-remove-unused-args
Jan 10, 2026
Merged

fix: invalid device state after bind#100
cmroche merged 3 commits intomasterfrom
fix-remove-unused-args

Conversation

@cmroche
Copy link
Owner

@cmroche cmroche commented Aug 11, 2024

Immediately call for as state update as soon as the device is bound, add a signal that can be used to check that the device has received it's first state update.

Removed unused, optional, wait_for parameter on update_state and send_device_state

CLOSES #99

@codecov
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.69%. Comparing base (ae13325) to head (6b8ac59).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
greeclimate/device.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   95.65%   95.69%   +0.04%     
==========================================
  Files           8        8              
  Lines         736      743       +7     
==========================================
+ Hits          704      711       +7     
  Misses         32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmroche cmroche changed the title Fix invalid device state after bind fix: invalid device state after bind Aug 11, 2024
@cmroche cmroche self-assigned this Aug 11, 2024
@AnicJov
Copy link

AnicJov commented Jul 9, 2025

Just bumping this PR to say that it worked for me. I wasn't getting any device state even after a bind() and update_state() but this patch fixes that, thanks. I hope it can get merged.

Immediately call for as state update as soon as the device is bound, add a signal that can be used to check that the device has received it's first state update.
Add test for request_version with timeout
@cmroche cmroche force-pushed the fix-remove-unused-args branch from fbf9748 to 6b8ac59 Compare January 10, 2026 15:14
@cmroche cmroche merged commit 07f0390 into master Jan 10, 2026
10 of 11 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 10, 2026
## [2.1.1](v2.1.0...v2.1.1) (2026-01-10)

### Bug Fixes

* invalid device state after bind ([#100](#100)) ([07f0390](07f0390))
@github-actions
Copy link

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Device returns invalid state after binding, and before first state update is received

2 participants