Open
Conversation
rchristie
suggested changes
Dec 16, 2022
Contributor
rchristie
left a comment
There was a problem hiding this comment.
Great work.
Field Editor needs to be updated for Hugh's latest changes to field editor, and that code also needs some fixes!
I get warning on build html:
~\sceneviewereditorwidget.rst: WARNING: document isn't included in any toctree
Some additional changes:
- scene-editor-widget.png - cmiss_number is not really suitable for a Subgroup field. I suggest using the field editor to create a constant field "left ventricle" with value 1 and choosing that for your graphics.
- field-editor-widget.png - need to remake image as it is missing the Field type section. Also, please don't use coordinates_cmiss_rc_wrapper as the selected example as it's an internal auto-generated field. If using the deforming heart example, I suggest using E2 as a good example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.