refactor+test: mutation hardening — extract helpers and kill survivors

[cmbays]

Summary

• Extract pure helper functions from three hotspot files into their helpers modules with targeted unit tests
• Replace inline endsWith JSON filters across 4 files with shared isJsonFile helper
• Export and test saved kata CRUD functions that previously had zero test coverage
• Add targeted unit tests for terminal-state dispatch rejection, diary writing guards, force bypass, synthesis depth override, and nextKeiko no-op paths

Mutation score improvement

File	Before	After	Survived delta
execute.ts	66.74%	69.21%	128 → 116
session-bridge.ts	74.40%	74.68%	45 → 38
cooldown-session.ts	65.38%	65.70%	49 → 48
Overall	71.33%	72.19%	234 → 215

19 surviving mutants killed. Focus on ConditionalExpression, LogicalOperator, EqualityOperator, BlockStatement, MethodExpression, ObjectLiteral mutants (StringLiteral skipped per #375).

New helpers extracted

cooldown-session.helpers.ts: isSyncableBet, collectBridgeRunIds, hasObservations, shouldSyncOutcomes, hasMethod

session-bridge.helpers.ts: findEarliestTimestamp, matchesCycleRef, resolveAgentId, computeBudgetPercent, extractHistoryTokenTotal, sumTokenTotals, countJsonlContent, mapBridgeRunStatus

execute.helpers.ts: hasNoGapsToBridge, hasBlockedGaps, hasBridgedGaps, formatConfidencePercent, hasPipelineLearnings

Test plan

• npm run typecheck passes
• npm run lint passes
• npm run test:unit — 3245 tests pass
• npm test (unit + integration) — all pass
• npm run test:mutation — 72.19% (above break threshold 70)
• CRAP analysis passes on changed files

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added public API for managing saved katas: list, load, save, and delete operations.
  • Enhanced budget and token tracking with improved calculations and reporting.
  • Improved file filtering and status handling across session management.

• Bug Fixes

  • Enhanced error handling for non-existent and terminal run states.
  • Better validation of gap bridging and outcome synchronization.

• Tests

  • Expanded test coverage for kata management, helper utilities, and session state transitions.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR extracts pure helper functions across execute, cooldown-session, and session-bridge modules, then refactors existing code to use these centralized utilities. New saved-kata CRUD functions are exported, and comprehensive test coverage is added for all new helpers and refactored workflows.

Changes

Cohort / File(s)	Summary
Execute command helpers src/cli/commands/execute.helpers.ts, src/cli/commands/execute.helpers.test.ts	Adds five pure helpers: hasNoGapsToBridge, hasBridgedGaps, hasBlockedGaps, formatConfidencePercent, hasPipelineLearnings; each tested for edge cases and typical usage.
Execute command refactoring src/cli/commands/execute.ts, src/cli/commands/execute.test.ts	Integrates new helpers into execute flow; exports four public CRUD functions for saved katas (listSavedKatas, loadSavedKata, saveSavedKata, deleteSavedKata) with error handling and comprehensive test coverage.
Cooldown session helpers src/features/cycle-management/cooldown-session.helpers.ts, src/features/cycle-management/cooldown-session.helpers.test.ts	Adds five helpers: isSyncableBet, collectBridgeRunIds, hasObservations, shouldSyncOutcomes, hasMethod; all stateless predicates and collectors with thorough edge-case testing.
Cooldown session refactoring src/features/cycle-management/cooldown-session.ts, src/features/cycle-management/cooldown-session.unit.test.ts	Replaces inline checks (length, pending-status, method existence) with new helpers; updates runExpiryCheck, loadBridgeRunIdsByBetId, and autoSyncBetOutcomesFromBridgeRuns; adds unit tests for writeRunDiary, complete, and run behavior under various config states.
Session bridge helpers src/infrastructure/execution/session-bridge.helpers.ts, src/infrastructure/execution/session-bridge.helpers.test.ts	Adds eight utilities: mapBridgeRunStatus, findEarliestTimestamp, matchesCycleRef, resolveAgentId, computeBudgetPercent, extractHistoryTokenTotal, sumTokenTotals, countJsonlContent; includes budget math, token extraction, and JSONL counting.
Session bridge refactoring src/infrastructure/execution/session-bridge.ts, src/infrastructure/execution/session-bridge.unit.test.ts	Centralizes JSON-file filtering via isJsonFile; replaces manual timestamp, cycle-ref, agent-id, token, and budget computations with helpers; adds three unit tests for getAgentContext rejection on terminal/non-existent runs.
Workflow runner filter update src/features/execute/workflow-runner.ts	Replaces endsWith('.json') string checks with centralized isJsonFile predicate in artifact scanning and listing.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~28 minutes

Possibly related PRs

• refactor: bounded extraction for mutation coverage hardening #384: Both PRs extract and apply overlapping pure helper functions (isJsonFile, session-bridge/cycle helpers) across multiple modules, centralizing commonly-used predicates and filters.
• fix: auto-sync bet outcomes from bridge-run metadata in cooldown (closes #216) #297: Both refactor cooldown-session auto-sync logic using new helpers (isSyncableBet, collectBridgeRunIds, hasObservations, shouldSyncOutcomes); the main PR consolidates these helpers that support bridge-run auto-sync workflows.
• Unify cycle launch through session bridge #380: Both add overlapping session-bridge helper utilities (cycle matching, agent ID resolution, budget calculations) and refactor call sites to use them consistently.

Poem

🐰 Helpers hop and gather near,
Pure and tested, crystal clear!
No more checks scattered 'round,
Centralized logic, safe and sound! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 70.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main objective: extracting helper functions (mutation hardening) and improving test coverage to eliminate surviving mutants.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch worktree-rosy-twirling-petal

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}