Skip to content

Conversation

@mitar
Copy link
Contributor

@mitar mitar commented Sep 20, 2014

Meteor.Error should get a numeric value for the first argument. And if callback is provided you should not be throwing an exception, user does not get any feedback (upload just gets stuck) and Meteor logs a strange error into the console, hard to understand why it failed.

@cmather
Copy link
Owner

cmather commented Sep 20, 2014

Cool thanks Mitar

On Sep 20, 2014, at 4:22 PM, Mitar notifications@github.com wrote:

Meteor.Error should get a numeric value for the first argument. And if callback is provided you should not be throwing an exception, user does not get any feedback (upload just gets stuck) and Meteor logs a strange error into the console, hard to understand why it failed.

You can merge this Pull Request by running

git pull https://github.com/peerlibrary/meteor-file handle-errors-better
Or view, comment on, or merge it at:

#20

Commit Summary

Better handle errors when using callbacks.
File Changes

M meteor-file.js (24)
Patch Links:

https://github.com/EventedMind/meteor-file/pull/20.patch
https://github.com/EventedMind/meteor-file/pull/20.diff

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants