Serialize JSON in a way that doesn't require duplicate calculations of Document hashes #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove local withDocument Remove println Put withDocument here instead
Clean up round trip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is coordinated with changes in processors and can only be used after processors is updated.
Uses of implicits and package files have been removed.
Much duplicated code has been removed.
Document hashes are stored temporarily and reused.
Several related issues have been filed.
TODOs have been added near problematic code.
The new output matches previous output except that roots are sorted and triggers get their actual class and not the generic TextBoundMention. All tests showed IDs being equal to their previous values, even when those values are problematic. Those fixes are scheduled for later.
There is still some debug output for timing that needs to be removed after further testing.