Shell buttons stopped working after scroll fix (#561)

[waleedkadous]

Bug

Shell buttons in the dashboard are no longer working. This started immediately after merging PR #561 (terminal scroll position fix) and restarting Tower.

Likely Cause

PR #561 modified Terminal.tsx — added term.onScroll() handler and changed safeFit() to use externally-tracked scroll state. Something in these changes may have broken event handling for shell buttons.

Key Changes in PR #561 to Investigate

1. Added scrollState object and term.onScroll() listener
2. Modified safeFit() to read from scrollState instead of term.buffer.active
3. Added scrollDisposable.dispose() to cleanup
4. Added scroll state sync in term.write() callback and replay timeout

Expected Behavior

Shell buttons should work as before PR #561.

Files to Investigate

• packages/codev/dashboard/src/components/Terminal.tsx — the only source file changed in PR Fix: Terminal scrolls to top after tab switch (Issue #560) #561

[waleedkadous]

On it! Working on a fix now.