Optimize all images and reduce image sizes #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
force-pushed
the
optimize_images
branch
3 times, most recently
from
40734bc to
0763d56
Compare
clue
reviewed
Jun 16, 2024
SimonFrings
force-pushed
the
optimize_images
branch
from
0763d56 to
0799c2c
Compare
clue
approved these changes
Jul 4, 2024
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset aims to optimize all images and to reduce image resolution to what would be the maximum image resolution at 2x DPR. In particular, this significantly reduces the transferred data from ~6.54 MB to ~3.1 MB, i.e. the previous version is ~2x larger. Additionally the download size for the blog pages are reduced here as well. Despite loading much faster, this should show no visible changes otherwise.
FYI: I also removed the
bg.jpgas this picture doesn't seem to be used anymore.Builds on top of clue/framework-x-website#35, #126 , #117 and others