Bugfixes and a few improvements #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 29, 2018 19:09
Fixes: - Prevent the use of /rules when in a bed (otherwise, player can drag and drops menu items into his inventory) - When reloading the plugin, rules menu is no more cleared (also before, user who didn't accept can then close it) Improvements: - Complete the plugin.yml (add author urls, declare permissions, ...) - Add a new permission "rules.*" - Allows to localize messages
Their slot number was not read from the configuration file, but hard coded.
- Allows to clear accept status for a single player (/rules -clear <player>) - Allows to flag a player as already having accepter (/rules -accept <player>) - Allows to check the accept status of a player (/rules -status <player>) - RulesConfirmedEvent is cancellable - When using /rules -clear, open the menu for online players (or for the player cleared only)
- Add a cancellable event fired when player refuses - Makes the kick action optional - Add a new permission: rules.exempt
onJoin and onClose didn't consider it, now fixed.
Author
|
I've created an addon for your plugin using those additions: Fell free to link it to your Spigot page if you integrate this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
(otherwise, player can drag and drops menu items into his inventory)
(also before, user who didn't accept can then close it)
Improvements:
Misc: