fix(devkit): improve snapshot pane shader navigation and scroll targeting#542
Open
xq-r wants to merge 3 commits intoclshortfuse:mainfrom
Open
fix(devkit): improve snapshot pane shader navigation and scroll targeting#542xq-r wants to merge 3 commits intoclshortfuse:mainfrom
xq-r wants to merge 3 commits intoclshortfuse:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves snapshot-pane navigation in the devkit overlay, specifically making shader-row navigation scroll to the exact shader entry and fixing scroll/clipper alignment issues in the snapshot table.
Changes:
- Introduces
SnapshotNavigationstate to support draw-level vs shader-level pending navigation and more accurate scroll targeting. - Fixes snapshot row height calculation to include table cell padding, improving
ImGuiListClipperbehavior and scroll offsets. - Updates navigation rendering to use list clipper inclusion for target rows and forces target draw nodes open when navigating to shader children.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.