feat(devkit): Devkit parallel compilation and slang support (AI GENERATED) by MohannedElfatih · Pull Request #474 · clshortfuse/renodx

MohannedElfatih · 2025-12-30T17:57:44Z

CMake:

Unify slangC and spirv flags and paths
Optionally run spirv-val and spirv-dis for easier debugging, generating spvasm files.

Devkit:

Add SPIRV Cross to show disassembly
Add slang compiler to load slang shaders from disk

Compiler:

Parallelize compilation for DXC, FXC and slang. Greatly reducing Load Shaders time (80 secs -> 10 secs on a 9800X3D).
mutexes are controlled through constexpr flags, FXC's mutex is enabeld (single threaded) because FXC isn't thread safe.

…d handle sm5_x files

Copilot

Pull request overview

This PR extends the devkit shader pipeline to support Slang-based disk shaders and SPIR-V inspection tools, and significantly reduces shader load time by parallelizing compilation across DXC/FXC/Slang.

Changes:

Add Slang shader compilation support (including SPIR-V disassembly/decompilation helpers).
Parallelize disk shader compilation in the watcher and add device-API–aware shader target resolution.
Update CMake shader build to unify Slang/SPIR-V flags/paths and optionally emit validation/disassembly artifacts.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/utils/shader_compiler_watcher.hpp	Adds Slang support, parallel compilation, and device-API–dependent target resolution.
src/utils/shader_compiler_slang.hpp	New Slang compiler runner plus SPIR-V disassembly/decompilation tooling via external executables.
src/utils/shader_compiler_directx.hpp	Makes DXC library loading thread-safe and introduces compile-time mutex toggles for parallelism.
src/addons/devkit/addon.cpp	Integrates Vulkan SPIR-V disassembly/decompilation and passes device API to the watcher.
CMakeLists.txt	Centralizes flags/paths for slangc + SPIR-V tools and adds optional spirv-val/spirv-dis outputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/utils/shader_compiler_slang.hpp

+#include <algorithm>
+#include <array>
+#include <atomic>
+#include <cctype>
+#include <cstdint>
+#include <cstring>
+#include <cstdlib>
+#include <exception>
+#include <filesystem>
+#include <mutex>
+#include <sstream>
+#include <shared_mutex>
+#include <span>
+#include <string>
+#include <vector>


src/utils/shader_compiler_watcher.hpp

+    for (auto& [shader_hash, custom_shader] : custom_shaders_cache) {
+      if (!shader_hashes_processed.contains(shader_hash)) {
+        if (!custom_shader.removed) {
+          custom_shader.removed = true;
+          shader_hashes_updated.insert(shader_hash);
+        }


src/utils/shader_compiler_watcher.hpp

+      if (shader_hashes_processed.contains(shader_hash)) {
+        std::stringstream s;
+        s << "CompileCustomShaders(Ignoring duplicate shader: ";
+        s << PRINT_CRC32(shader_hash);
+        s << ", at " << item.entry_path;
+        s << ")";
+        reshade::log::message(reshade::log::level::warning, s.str().c_str());
+        continue;


CMakeLists.txt

+      if(SPIRV_DIS_BIN)
+        add_custom_command(
+          OUTPUT ${EMBED_FOLDER}/${SHADER_HASH}.spvasm
+          COMMAND "${SPIRV_DIS_BIN}" "${EMBED_FOLDER}/${SHADER_HASH}.spv" -o "${EMBED_FOLDER}/${SHADER_HASH}.spvasm"
+          DEPENDS ${FILE}
+        )


CMakeLists.txt

+        add_custom_command(
+          OUTPUT ${EMBED_FOLDER}/${SHADER_NAME}.spvasm
+          COMMAND "${SPIRV_DIS_BIN}" "${EMBED_FOLDER}/${SHADER_NAME}.spv" -o "${EMBED_FOLDER}/${SHADER_NAME}.spvasm"
+          DEPENDS ${FILE}


Copilot

Pull request overview

This PR extends the devkit shader toolchain by adding Slang shader support and SPIR-V disassembly/decompilation tooling, while also parallelizing shader compilation to reduce live-reload “Load Shaders” time.

Changes:

Parallelize custom shader compilation in the watcher (DXC/FXC/Slang) and add device-API–aware target resolution.
Add a Slang-based compiler wrapper that can compile .slang shaders from disk and optionally disassemble/decompile SPIR-V via external tools.
Update CMake shader build steps to unify Slang flags and optionally run spirv-val / produce .spvasm via spirv-dis.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/utils/shader_compiler_watcher.hpp	Adds Slang integration and parallel compilation pipeline for disk shaders.
src/utils/shader_compiler_slang.hpp	Introduces Slang compiler invocation plus SPIR-V disassembly/decompilation helpers.
src/utils/shader_compiler_directx.hpp	Adjusts DXC loading and makes DXC/FXC locking behavior configurable for parallelism.
src/addons/devkit/addon.cpp	Hooks watcher device API, adds Vulkan disassembly/decompilation paths, and tweaks UI link selection behavior.
CMakeLists.txt	Unifies Slang flags/paths and adds optional `spirv-val`/`spirv-dis` steps and auxiliary outputs.

Comments suppressed due to low confidence (1)

src/utils/shader_compiler_directx.hpp:134

LoadDXCompiler now uses std::call_once but still accepts a path parameter. After the first call (even if it fails or uses a different path), subsequent calls cannot retry with another path and will keep returning the cached result. Either remove the path parameter or implement retry/path-aware caching so callers can load from a non-default location when needed.

inline HMODULE LoadDXCompiler(const std::wstring& path = L"dxcompiler.dll") {
  std::call_once(dxc_compiler_library_once, [&]() {
    dxc_compiler_library = LoadLibraryW(path.c_str());
  });
  return dxc_compiler_library;
}

// Narrow-string overloads for convenience
inline HMODULE LoadDXCompiler(const std::string& path) {
  return LoadDXCompiler(std::wstring(path.begin(), path.end()));
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-06T13:17:24Z

src/utils/shader_compiler_slang.hpp

+#include <algorithm>
+#include <array>
+#include <atomic>
+#include <cctype>
+#include <cstdint>
+#include <cstring>
+#include <cstdlib>
+#include <exception>
+#include <filesystem>
+#include <mutex>
+#include <sstream>
+#include <shared_mutex>
+#include <span>
+#include <string>
+#include <vector>
+
+#include "./path.hpp"
+
+namespace renodx::utils::shader::compiler::slang {
+
+namespace internal {
+
+static std::shared_mutex mutex_slangc_path;
+static std::filesystem::path cached_slangc_path;
+static std::atomic_uint32_t compile_counter = 0;
+static std::optional<std::filesystem::path> cached_spirv_dis;
+static std::optional<std::filesystem::path> cached_spirv_cross;


shader_compiler_slang.hpp uses std::optional for cached tool paths, but the header does not include <optional>. This makes the header non-self-contained and can break compilation depending on include order; add the missing standard header include here.

Copilot · 2026-04-06T13:17:25Z

src/utils/shader_compiler_watcher.hpp

+          previous_custom_shader.is_hlsl = custom_shader.is_hlsl;
+          previous_custom_shader.is_glsl = custom_shader.is_glsl;
+          previous_custom_shader.is_slang = custom_shader.is_slang;
+          previous_custom_shader.file_path = custom_shader.file_path;


When the compiled bytecode matches an existing cache entry, the code updates the source metadata but does not clear previous_custom_shader.removed. If a shader was previously marked removed and then re-added with identical output, it will stay marked as removed and may never become active again; ensure removed is reset to false when the shader is seen again.

Suggested change

previous_custom_shader.file_path = custom_shader.file_path;

previous_custom_shader.file_path = custom_shader.file_path;

previous_custom_shader.removed = false;

Copilot · 2026-04-06T13:17:25Z

CMakeLists.txt

+      if(SPIRV_DIS_BIN)
+        add_custom_command(
+          OUTPUT ${EMBED_FOLDER}/${SHADER_HASH}.spvasm
+          COMMAND "${SPIRV_DIS_BIN}" "${EMBED_FOLDER}/${SHADER_HASH}.spv" -o "${EMBED_FOLDER}/${SHADER_HASH}.spvasm"
+          DEPENDS ${FILE}
+        )


This spirv-dis custom command depends on the original ${FILE} rather than the generated/copied ${EMBED_FOLDER}/${SHADER_HASH}.spv. That can allow CMake to schedule spirv-dis before the .spv exists, causing build failures. Make the .spvasm rule depend on the .spv output (and/or add it as a byproduct of the .spv rule).

Copilot · 2026-04-06T13:17:25Z

CMakeLists.txt

+        add_custom_command(
+          OUTPUT ${EMBED_FOLDER}/${SHADER_NAME}.spvasm
+          COMMAND "${SPIRV_DIS_BIN}" "${EMBED_FOLDER}/${SHADER_NAME}.spv" -o "${EMBED_FOLDER}/${SHADER_NAME}.spvasm"
+          DEPENDS ${FILE}


Same issue as above for the non-hash path: the spirv-dis .spvasm rule depends on ${FILE} instead of ${EMBED_FOLDER}/${SHADER_NAME}.spv, so the disassembly step may run before the .spv output is generated. Update the dependency to the .spv output to guarantee correct build ordering.

Suggested change

DEPENDS ${FILE}

DEPENDS ${EMBED_FOLDER}/${SHADER_NAME}.spv

MohannedElfatih added 2 commits December 30, 2025 21:43

feat(devkit): Add slang support (Using Vulkan SDK)

b1563ca

feat(devkit): Parallelize shader compilation (dxc, fxc and slang), an…

6f0f7ca

…d handle sm5_x files

clshortfuse requested a review from Copilot March 13, 2026 03:18

Copilot started reviewing on behalf of clshortfuse March 13, 2026 03:19 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

clshortfuse requested a review from Copilot April 6, 2026 13:11

Copilot started reviewing on behalf of clshortfuse April 6, 2026 13:12 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(devkit): Devkit parallel compilation and slang support (AI GENERATED)#474

feat(devkit): Devkit parallel compilation and slang support (AI GENERATED)#474
MohannedElfatih wants to merge 2 commits intoclshortfuse:mainfrom
MohannedElfatih:devkit-parallel-slang

MohannedElfatih commented Dec 30, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	previous_custom_shader.file_path = custom_shader.file_path;
	previous_custom_shader.file_path = custom_shader.file_path;
	previous_custom_shader.removed = false;

Uh oh!

Conversation

MohannedElfatih commented Dec 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants