Skip to content

Conversation

@AsterDY
Copy link
Contributor

@AsterDY AsterDY commented Oct 17, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: support passing dynamicgo's IDL option by ProviderOption.DynamicgoOptions
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@AsterDY AsterDY requested review from a team as code owners October 17, 2025 08:20
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.35%. Comparing base (bfa27f3) to head (a020dcd).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/generic/thriftidl_provider.go 82.60% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1878      +/-   ##
==========================================
- Coverage   61.37%   61.35%   -0.03%     
==========================================
  Files         388      388              
  Lines       35063    29857    -5206     
==========================================
- Hits        21521    18319    -3202     
+ Misses      12247    10241    -2006     
- Partials     1295     1297       +2     
Flag Coverage Δ
integration 51.77% <7.40%> (+1.26%) ⬆️
unit 51.60% <85.18%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AsterDY AsterDY force-pushed the feat/dg_force_hash branch 2 times, most recently from c0e3797 to 2c3bb44 Compare October 20, 2025 04:56
@AsterDY AsterDY force-pushed the feat/dg_force_hash branch from cfc2077 to ee42d09 Compare October 29, 2025 06:22
@AsterDY AsterDY changed the title feat: support passing dynamicgo's parsing option by ProviderOption.DynamicgoOptions feat: support passing dynamicgo's parsing option Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants