Skip to content

feat: allow specification of revisionHistoryLimit on certificates #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianroberts wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow specification of revisionHistoryLimit on certificates #763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/plugin-barman-cloud/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Helm Chart for CloudNativePG's CNPG-I backup plugin using Barman Cloud
| certificate.duration | string | `"2160h"` | The duration of the certificates. |
| certificate.issuerName | string | `"selfsigned-issuer"` | The name of the issuer to use for the certificates. |
| certificate.renewBefore | string | `"360h"` | The renew before time for the certificates. |
| certificate.revisionHistoryLimit | int | `1` | The maximum number of CertificateRequests to retain for each certificate. |
| commonAnnotations | object | `{}` | Annotations to be added to all other resources. |
| containerSecurityContext | object | `{"allowPrivilegeEscalation":false,"capabilities":{"drop":["ALL"]},"readOnlyRootFilesystem":true,"runAsGroup":10001,"runAsUser":10001,"seccompProfile":{"type":"RuntimeDefault"}}` | Container Security Context. |
| crds.create | bool | `true` | Specifies whether the CRDs should be created when installing the chart. |
Expand Down
3 changes: 3 additions & 0 deletions charts/plugin-barman-cloud/templates/client-certificate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ spec:
kind: Issuer
name: {{ include "plugin-barman-cloud.fullname" . }}-selfsigned-issuer
renewBefore: {{ .Values.certificate.renewBefore | default "360h" }}
{{- with .Values.certificate.revisionHistoryLimit }}
revisionHistoryLimit: {{ . }}
{{- end }}
secretName: barman-cloud-client-tls
usages:
- client auth
Expand Down
3 changes: 3 additions & 0 deletions charts/plugin-barman-cloud/templates/server-certificate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ spec:
kind: Issuer
name: {{ include "plugin-barman-cloud.fullname" . }}-selfsigned-issuer
renewBefore: {{ .Values.certificate.renewBefore | default "360h" }}
{{- with .Values.certificate.revisionHistoryLimit }}
revisionHistoryLimit: {{ . }}
{{- end }}
secretName: barman-cloud-server-tls
usages:
- server auth
Expand Down
10 changes: 9 additions & 1 deletion charts/plugin-barman-cloud/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,22 @@
"required": [],
"title": "renewBefore",
"type": "string"
},
"revisionHistoryLimit": {
"default": 1,
"description": "The maximum number of CertificateRequests to retain for each certificate.",
"required": [],
"title": "revisionHistoryLimit",
"type": "integer"
}
},
"required": [
"createClientCertificate",
"createServerCertificate",
"issuerName",
"duration",
"renewBefore"
"renewBefore",
"revisionHistoryLimit"
],
"title": "certificate",
"type": "object"
Expand Down
2 changes: 2 additions & 0 deletions charts/plugin-barman-cloud/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,3 +195,5 @@ certificate:
duration: 2160h
# -- The renew before time for the certificates.
renewBefore: 360h
# -- The maximum number of CertificateRequests to retain for each certificate.
revisionHistoryLimit: 1