Skip to content

feat(plugin-barman-cloud): make actual use of issuer name from values #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pascaliske wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(plugin-barman-cloud): make actual use of issuer name from values #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions charts/plugin-barman-cloud/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,10 @@ Create the name of the service account to use
{{- default "default" .Values.serviceAccount.name }}
{{- end }}
{{- end }}

{{/*
Create the name of the certificate issuer to use
*/}}
{{- define "plugin-barman-cloud.certificateIssuerName" -}}
{{- default (printf "%s-selfsigned-issuer" (include "plugin-barman-cloud.fullname" .)) .Values.certificate.issuerName }}
{{- end }}
2 changes: 1 addition & 1 deletion charts/plugin-barman-cloud/templates/certificate-issuer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
name: {{ include "plugin-barman-cloud.fullname" . }}-selfsigned-issuer
name: {{ include "plugin-barman-cloud.certificateIssuerName" . }}
namespace: {{ include "plugin-barman-cloud.namespace" . }}
spec:
selfSigned: {}
2 changes: 1 addition & 1 deletion charts/plugin-barman-cloud/templates/client-certificate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
issuerRef:
group: cert-manager.io
kind: Issuer
name: {{ include "plugin-barman-cloud.fullname" . }}-selfsigned-issuer
name: {{ include "plugin-barman-cloud.certificateIssuerName" . }}
renewBefore: {{ .Values.certificate.renewBefore | default "360h" }}
secretName: barman-cloud-client-tls
usages:
Expand Down
2 changes: 1 addition & 1 deletion charts/plugin-barman-cloud/templates/server-certificate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ spec:
issuerRef:
group: cert-manager.io
kind: Issuer
name: {{ include "plugin-barman-cloud.fullname" . }}-selfsigned-issuer
name: {{ include "plugin-barman-cloud.certificateIssuerName" . }}
renewBefore: {{ .Values.certificate.renewBefore | default "360h" }}
secretName: barman-cloud-server-tls
usages:
Expand Down
2 changes: 1 addition & 1 deletion charts/plugin-barman-cloud/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ certificate:
# -- Specifies whether the server certificate should be created.
createServerCertificate: true
# -- The name of the issuer to use for the certificates.
issuerName: selfsigned-issuer
issuerName: ''
# -- The duration of the certificates.
duration: 2160h
# -- The renew before time for the certificates.
Expand Down