Skip to content

Conversation

@serdarozerr
Copy link
Contributor

Context

The integration tests previously ran in a Concourse pipeline. As part of consolidating all clis into storage-cli repository, the Concourse pipelines needed to be fully migrated to GitHub Workflows.

Solution

A new GitHub Workflow has been introduced. The workflow includes one job, alioss-general-integration-tests. Helper scripts like: setup, run, teardown created. With that each job can create the required Ali oss bucket dynamically during execution and cleans them up afterward.
All secrets needed for provisioning these resources are stored under the secrets in GitHub.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Alioss integration tests from a Concourse pipeline to a GitHub Workflow, consolidating CI/CD operations within the storage-cli repository. The implementation introduces helper scripts that dynamically provision and clean up Alibaba OSS buckets during test execution.

Key Changes:

  • Added GitHub Workflow (.github/workflows/alioss-integration.yml) that orchestrates integration tests with dynamic bucket provisioning
  • Created helper scripts (setup.sh, run-int.sh, teardown.sh) to manage test environment lifecycle
  • Updated documentation in alioss/README.md to reflect new testing procedures

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
.github/workflows/alioss-integration.yml New GitHub Actions workflow for running Alioss integration tests on pull requests
.github/scripts/alioss/utils.sh Utility functions for bucket management, Aliyun CLI configuration, and file-based bucket name tracking
.github/scripts/alioss/setup.sh Script to initialize test environment by creating dynamically named OSS buckets
.github/scripts/alioss/run-int.sh Script to execute integration tests with proper environment variable configuration
.github/scripts/alioss/teardown.sh Cleanup script to delete test buckets after test execution
alioss/README.md Updated documentation with separate unit and integration test instructions, including manual setup guide

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fmoehler
fmoehler previously approved these changes Nov 21, 2025
@github-project-automation github-project-automation bot moved this from Pending Review | Discussion to Pending Merge | Prioritized in Foundational Infrastructure Working Group Nov 21, 2025
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Nov 21, 2025
@github-project-automation github-project-automation bot moved this from Waiting for Changes | Open for Contribution to Pending Merge | Prioritized in Foundational Infrastructure Working Group Nov 21, 2025
@stephanme stephanme merged commit 33eb49f into cloudfoundry:main Nov 21, 2025
3 of 4 checks passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants