Open
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
johha
requested review from
a team,
Sascha-Stoj and
gururajsh
and removed request for
a team
johha
force-pushed
the
s3-multipart-copy
branch
from
dc253e5 to
d316e32
Compare
serdarozerr
reviewed
Feb 13, 2026
| // multipartCopy performs a multipart copy using CreateMultipartUpload, UploadPartCopy, and CompleteMultipartUpload | ||
| func (b *awsS3Client) multipartCopy(copySource string, dstBlob string, objectSize int64, copyPartSize int64) error { | ||
| cfg := b.s3cliConfig | ||
| numParts := int((objectSize + copyPartSize - 1) / copyPartSize) |
Contributor
There was a problem hiding this comment.
maybe adding a comment in here makes more clear how the number of parts are calculated
example: ceiling division formula
and alternative formula ((objectSize - 1) / o.copyPartSize) + 1
| return errors.New("object content length is nil") | ||
| } | ||
|
|
||
| objectSize := *headOutput.ContentLength |
Contributor
There was a problem hiding this comment.
could be better to return if objectSize is 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS S3 requires multipart copy for files larger than 5GB. Other providers might have different levels thus this value is configurable.