-
Notifications
You must be signed in to change notification settings - Fork 3
(feat): make S3 transfer concurrency, part size, checksum configurable #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
a-hassanin
merged 4 commits into
cloudfoundry:main
from
gowrisankar22:s3cli-support-concurrency
Feb 4, 2026
Merged
(feat): make S3 transfer concurrency, part size, checksum configurable #29
a-hassanin
merged 4 commits into
cloudfoundry:main
from
gowrisankar22:s3cli-support-concurrency
Feb 4, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hassanin
requested changes
Jan 30, 2026
serdarozerr
reviewed
Jan 30, 2026
Contributor
serdarozerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just some minor suggestions
serdarozerr
approved these changes
Feb 2, 2026
johha
previously approved these changes
Feb 3, 2026
35 tasks
neddp
reviewed
Feb 4, 2026
neddp
approved these changes
Feb 4, 2026
johha
approved these changes
Feb 4, 2026
a-hassanin
approved these changes
Feb 4, 2026
a-hassanin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same changes as cloudfoundry/bosh-s3cli#61
Problem
The BOSH S3 CLI currently uses AWS SDK V2 defaults for S3 uploads and downloads, which are significantly lower than other CLI tools, resulting in suboptimal performance example for https://docs.cloud.google.com/distributed-cloud/docs
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/feature/s3/manager#Downloader
These conservative defaults were designed for general-purpose use cases but create a bottleneck for BOSH operations that require higher throughput. Unlike the AWS CLI, which offers tunable parameters, there was no way for users to optimize transfer performance based on their specific infrastructure requirements and network conditions.
Solution
This PR makes S3 transfer concurrency and part size configurable, allowing operators to:
These properties are purely optional and users can choose if they really need to change the default behavior. At least for google's new air-gapped offering we needed. https://docs.cloud.google.com/distributed-cloud/docs
AWS SDK Compatibility (CRC64NVME): The latest bosh-s3cli uses the newest AWS SDK V2, which defaults to x-amz-sdk-checksum-algorithm:CRC64NVME. This has caused compatibility issues to GDCH.
Solution
In the interim, we have to disable this behavior using the configurable parameter
disable_checksums.Minor improvement --> fixing the pascalcase for
RequestChecksumCalculationEnabledandUploaderRequestChecksumCalculationEnabled