Skip to content

Disables watching the private key file for updates #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pivotal-david-osullivan merged 1 commit into from
Apr 5, 2023
Merged

Disables watching the private key file for updates #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/org/cloudfoundry/security/FileWatchingX509ExtendedKeyManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ final class FileWatchingX509ExtendedKeyManager extends X509ExtendedKeyManager {
this.keyManagerFactory = keyManagerFactory;

new FileWatcher(this.certificates, new FileWatcherCallback()).watch();
new FileWatcher(this.privateKey, new FileWatcherCallback()).watch();
// disable watching the key file to prevent race condition bug - a certificate file change covers the key change
// new FileWatcher(this.privateKey, new FileWatcherCallback()).watch();

if (this.keyManager.compareAndSet(null, getKeyManager(getKeyStore()))) {
this.logger.info(String.format("Initialized KeyManager for %s and %s", this.privateKey, this.certificates));
Expand Down