Improve setup and shutdown of periodic_updater #4737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puma shutdown can race with background metrics TimerTasks, which can lead to non-deterministic termination of threads (including database connections). Use 'kill' instead of 'shutdown' to dismiss already enqueued tasks while still allowing in-progress tasks to complete. Then call 'wait_for_termination' with a timeout of 1 second and return 'true' only if all tasks terminated successfully. This enables accurate logging (Successfully stopped periodic updates vs. Failed to stop all periodic update tasks). Instead of calling all 'update_*' methods explicitly in the beginning, configure TimerTasks with 'run_now: true'. Also set 'interval_type: :fixed_rate' so execution timing is deterministic and independent of task duration.
philippthun
force-pushed
the
periodic-updater-improved-setup-and-shutdown
branch
from
4174f53 to
1a3590f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puma shutdown can race with background metrics
TimerTasks, which can lead to non-deterministic termination of threads (including database connections).Use
killinstead ofshutdownto dismiss already enqueued tasks while still allowing in-progress tasks to complete. Then callwait_for_terminationwith a timeout of 1 second and returntrueonly if all tasks terminated successfully. This enables accurate logging (Successfully stopped periodic updatesvs.Failed to stop all periodic update tasks).Instead of calling all
update_*methods explicitly in the beginning, configureTimerTasks withrun_now: true. Also setinterval_type: :fixed_rateso execution timing is deterministic and independent of task duration.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests